third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h - Issue 1404853003: Add SVG Text to support the CSS 'text-orientation' property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1404853003: Add SVG Text to support the CSS 'text-orientation' property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fs review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp » ('j') | third_party/WebKit/Source/platform/fonts/FontOrientation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

index 469ee41c182f4ed6a8eff383aaedd28de9fb90a1..7432ad8199e7bbe5d1af532325050cf68287dcf9 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

@@ -25,6 +25,7 @@

namespace blink {

+enum class FontOrientation;

class LayoutSVGInlineText;

class TextRun;

@@ -48,6 +49,9 @@ public:

void setWidth(float width) { m_width = width; }

float height() const { return m_height; }

+ // TODO(kojii): We should store logical width (advance) and height instead

drott 2015/10/19 07:00:04 Could you add a bug report and reference it from h

+ // of storing physical and calculate logical.

+ float advance(FontOrientation) const;

unsigned length() const { return m_length; }

private: