Quell warnings for exclusion list dictionaries in MSVS generator.

pylib/gyp/MSVSSettings.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Code to validate and convert settings of the Microsoft build tools.
 
 This file contains code to validate and convert settings of the Microsoft
 build tools.  The function ConvertToMSBuildSettings(), ValidateMSVSSettings(),
 and ValidateMSBuildSettings() are the entry points.
 
@@ skipping 385 matching lines @@
         '$(ParentName)': '$(ProjectFileName)',
         '$(PlatformName)': '$(Platform)',
         '$(SafeInputName)': '%(Filename)',
     }
     for old, new in replace_map.iteritems():
       s = s.replace(old, new)
     s = FixVCMacroSlashes(s)
   return s
 
 
+_EXCLUDED_SUFFIX_RE = re.compile('^(.*)_excluded$')
+
+
 def ConvertToMSBuildSettings(msvs_settings, stderr=sys.stderr):
   """Converts MSVS settings (VS2008 and earlier) to MSBuild settings (VS2010+).
 
   Args:
       msvs_settings: A dictionary.  The key is the tool name.  The values are
           themselves dictionaries of settings and their values.
       stderr: The stream receiving the error messages.
 
   Returns:
       A dictionary of MSBuild settings.  The key is either the MSBuild tool name
       or the empty string (for the global settings).  The values are themselves
       dictionaries of settings and their values.
   """
   msbuild_settings = {}
   for msvs_tool_name, msvs_tool_settings in msvs_settings.iteritems():
     if msvs_tool_name in _msvs_to_msbuild_converters:
       msvs_tool = _msvs_to_msbuild_converters[msvs_tool_name]
       for msvs_setting, msvs_value in msvs_tool_settings.iteritems():
         if msvs_setting in msvs_tool:
           # Invoke the translation function.
           try:
             msvs_tool[msvs_setting](msvs_value, msbuild_settings)
           except ValueError, e:
             print >> stderr, ('Warning: while converting %s/%s to MSBuild, '
                               '%s' % (msvs_tool_name, msvs_setting, e))
         else:
-          # We don't know this setting.  Give a warning.
-          print >> stderr, ('Warning: unrecognized setting %s/%s '
-                            'while converting to MSBuild.' %
-                            (msvs_tool_name, msvs_setting))
+          # This may be unrecognized because it's an exclusion list. If the
+          # setting name has the _excluded suffix, then check the root name.
+          unrecognized = True
+          m = re.match(_EXCLUDED_SUFFIX_RE, msvs_setting)
+          if m:
+            root_msvs_setting = m.group(1)
+            unrecognized = root_msvs_setting not in msvs_tool
+
+          if unrecognized:
+            # We don't know this setting. Give a warning.
+            print >> stderr, ('Warning: unrecognized setting %s/%s '
+                              'while converting to MSBuild.' %
+                              (msvs_tool_name, msvs_setting))
     else:
       print >> stderr, ('Warning: unrecognized tool %s while converting to '
                         'MSBuild.' % msvs_tool_name)
   return msbuild_settings
 
 
 def ValidateMSVSSettings(settings, stderr=sys.stderr):
   """Validates that the names of the settings are valid for MSVS.
 
   Args:
@@ skipping 596 matching lines @@
 _MSVSOnly(_manifest, 'UseUnicodeResponseFiles', _boolean)
 
 # MSBuild options not found in MSVS.
 _MSBuildOnly(_manifest, 'EnableDPIAwareness', _boolean)
 _MSBuildOnly(_manifest, 'GenerateCategoryTags', _boolean)  # /category
 _MSBuildOnly(_manifest, 'ManifestFromManagedAssembly',
              _file_name)  # /managedassemblyname
 _MSBuildOnly(_manifest, 'OutputResourceManifests', _string)  # /outputresource
 _MSBuildOnly(_manifest, 'SuppressDependencyElement', _boolean)  # /nodependency
 _MSBuildOnly(_manifest, 'TrackerLogDirectory', _folder_name)