Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 140483003: Quell warnings for exclusion list dictionaries in MSVS generator. (Closed)

Created:
6 years, 11 months ago by chrisha
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Quell warnings for exclusion list dictionaries in MSVS generator. When using ! or / filtering mechanisms on MSVS tool dictionaries, the resulting automatically created exclusion list dictionary causes the generator to complain that the setting name is unknown. This silences these spurious warnings. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1845

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M pylib/gyp/MSVSSettings.py View 2 chunks +16 lines, -4 lines 0 comments Download
M pylib/gyp/MSVSSettings_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chrisha
PTAL
6 years, 11 months ago (2014-01-24 20:09:41 UTC) #1
scottmg
lgtm
6 years, 11 months ago (2014-01-24 20:24:23 UTC) #2
chrisha
Thanks, committing.
6 years, 11 months ago (2014-01-24 20:26:25 UTC) #3
chrisha
6 years, 11 months ago (2014-01-24 20:40:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698