Issue 14048015: Skip copytexsubimage2D code path when src is multisampled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14048015: Skip copytexsubimage2D code path when src is multisampled. (Closed)

Created:
7 years, 8 months ago by bsalomon

Modified:
7 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Skip copytexsubimage2D code path when src is multisampled. Committed: https://code.google.com/p/skia/source/detail?r=8722

Patch Set 2 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	src/gpu/gl/GrGpuGL.cpp	View	1	2 chunks	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm https://codereview.chromium.org/14048015/diff/3001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/14048015/diff/3001/src/gpu/gl/GrGpuGL.cpp#newcode2264 src/gpu/gl/GrGpuGL.cpp:2264: } Does it make any sense to make ...

7 years, 8 months ago (2013-04-17 14:22:26 UTC) #2

bsalomon

Committed patchset #2 manually as r8722 (presubmit successful).

7 years, 8 months ago (2013-04-17 14:25:33 UTC) #3

bsalomon

7 years, 8 months ago (2013-04-18 18:09:33 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14048015/diff/3001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/14048015/diff/3001/src/gpu/gl/GrGpuGL.cpp#new...
src/gpu/gl/GrGpuGL.cpp:2264: }
On 2013/04/17 14:22:26, robertphillips wrote:
> Does it make any sense to make this a test on GrSurface (e.g., isCopyable)?

Hmm... it's really a GL-specific thing.

Expand Messages | Collapse Messages

Issue 14048015: Skip copytexsubimage2D code path when src is multisampled. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages