chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java - Issue 1404793006: Remove certain context menu items for images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Issue 1404793006: Remove certain context menu items for images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: newt's nits Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java ('k') | chrome/test/data/android/contextmenu/context_menu_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

index b3eb87256ece6eec3336943302286ce690007d9c..73ceea9e1b5d3f83eafe5c38c6fd52959a614049 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

@@ -175,13 +175,11 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {

public void testContextMenuEntriesForImage() throws InterruptedException, TimeoutException {

startCustomTabActivityWithIntent(createMinimalCustomTabIntent());

- final int expectedMenuSize = 4;

+ final int expectedMenuSize = 2;

Menu menu = ContextMenuUtils.openContextMenu(this, getActivity().getActivityTab(), "logo");

assertEquals(expectedMenuSize, menu.size());

assertNotNull(menu.findItem(R.id.contextmenu_save_image));

assertNotNull(menu.findItem(R.id.contextmenu_open_image));

- assertNotNull(menu.findItem(R.id.contextmenu_copy_image));

- assertNotNull(menu.findItem(R.id.contextmenu_copy_image_url));

}

/**