Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1404793002: [Interpreter]: Fix ObjectLiterals test for arm64-sim-nosnap bot. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Fix ObjectLiterals test for arm64-sim-nosnap bot. The AccessorsTable has a non-deterministic iteration order depending on the random seed. This means that the order of the accessor defines could vary and the test which tried to set accessors on two different properties could flakly fail due to the order not being as expected. To fix this I make the test only do a setter on one property (the test-interpreter.cc test does the check on multiple property accessors BUG=v8:4280 LOG=N Committed: https://crrev.com/1919fa38c2947cb3f3b1986b292fa5cfc7388eb0 Cr-Commit-Position: refs/heads/master@{#31264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rmcilroy
PTAL, thanks.
5 years, 2 months ago (2015-10-14 14:09:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404793002/1
5 years, 2 months ago (2015-10-14 14:10:03 UTC) #4
oth
lgtm. thanks!
5 years, 2 months ago (2015-10-14 14:15:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404793002/1
5 years, 2 months ago (2015-10-14 14:34:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 14:51:59 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 14:52:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1919fa38c2947cb3f3b1986b292fa5cfc7388eb0
Cr-Commit-Position: refs/heads/master@{#31264}

Powered by Google App Engine
This is Rietveld 408576698