Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1404673003: net/websockets: Use the (U)INTx_{MIN,MAX} macros from stdint.h (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
Adam Rice, eroman, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net/websockets: Use the (U)INTx_{MIN,MAX} macros from stdint.h Instead of making use of the deprecated types we have in basictypes.h. BUG=138542, 487868, 488550, 539734 TEST=net_unittests R=ricea@chromium.org,eroman@chromium.org,wtc@chromium.org Committed: https://crrev.com/20ced667164ff065e2c9998102cb0ebf31ccd085 Cr-Commit-Position: refs/heads/master@{#353911}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M net/websockets/websocket_frame.cc View 4 chunks +5 lines, -8 lines 2 comments Download
M net/websockets/websocket_frame_parser.cc View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tfarina
5 years, 2 months ago (2015-10-13 20:59:10 UTC) #1
eroman
lgtm
5 years, 2 months ago (2015-10-13 21:34:13 UTC) #2
Adam Rice
lgtm
5 years, 2 months ago (2015-10-13 23:01:43 UTC) #3
wtc
LGTM. https://codereview.chromium.org/1404673003/diff/1/net/websockets/websocket_frame.cc File net/websockets/websocket_frame.cc (left): https://codereview.chromium.org/1404673003/diff/1/net/websockets/websocket_frame.cc#oldcode8 net/websockets/websocket_frame.cc:8: #include <stdint.h> IMPORTANT: did you intend to remove ...
5 years, 2 months ago (2015-10-13 23:31:36 UTC) #5
tfarina
https://codereview.chromium.org/1404673003/diff/1/net/websockets/websocket_frame.cc File net/websockets/websocket_frame.cc (left): https://codereview.chromium.org/1404673003/diff/1/net/websockets/websocket_frame.cc#oldcode8 net/websockets/websocket_frame.cc:8: #include <stdint.h> On 2015/10/13 23:31:35, wtc wrote: > > ...
5 years, 2 months ago (2015-10-13 23:35:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404673003/1
5 years, 2 months ago (2015-10-13 23:38:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:48:47 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:49:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20ced667164ff065e2c9998102cb0ebf31ccd085
Cr-Commit-Position: refs/heads/master@{#353911}

Powered by Google App Engine
This is Rietveld 408576698