History UI: Apply the pref that prohibits deleting browsing and download history.

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
 
@@ skipping 108 matching lines @@
   var isSearchResult = propertyBag.isSearchResult || false;
   var addTitleFavicon = propertyBag.addTitleFavicon || false;
   var useMonthDate = propertyBag.useMonthDate || false;
   var node = createElementWithClassName('li', 'entry');
   var time = createElementWithClassName('div', 'time');
   var entryBox = createElementWithClassName('label', 'entry-box');
   var domain = createElementWithClassName('div', 'domain');
 
   this.id_ = this.model_.nextVisitId_++;
 
-  // Checkbox is always created, but only visible on hover & when checked.
-  var checkbox = document.createElement('input');
-  checkbox.type = 'checkbox';
-  checkbox.id = 'checkbox-' + this.id_;
-  checkbox.time = this.date.getTime();
-  checkbox.addEventListener('click', checkboxClicked);
-  time.appendChild(checkbox);
+  // Only create the checkbox if it can be used either to delete an entry or to
+  // block/allow it.
+  if (this.model_.createEditingCheckboxes) {

[James Hawkins, 2013/04/24 21:12:20]

Should this param be less imperative and more behavioral, e.g.,
this.model_.somePrefAllowed?

[Pam (message me for reviews), 2013/04/25 07:53:24]

Renamed to editingEntriesAllowed.

+    var checkbox = document.createElement('input');
+    checkbox.type = 'checkbox';
+    checkbox.id = 'checkbox-' + this.id_;
+    checkbox.time = this.date.getTime();
+    checkbox.addEventListener('click', checkboxClicked);
+    time.appendChild(checkbox);
+
+    // Clicking anywhere in the entryBox will check/uncheck the checkbox.
+    entryBox.setAttribute('for', checkbox.id);
+    entryBox.addEventListener('mousedown', entryBoxMousedown);
+  }
 
   // Keep track of the drop down that triggered the menu, so we know
   // which element to apply the command to.
   // TODO(dubroy): Ideally we'd use 'activate', but MenuButton swallows it.
   var self = this;
   var setActiveVisit = function(e) {
     activeVisit = self;
     var menu = $('action-menu');
     menu.dataset.devicename = self.deviceName;
     menu.dataset.devicetype = self.deviceType;
   };
   domain.textContent = this.getDomainFromURL_(this.url_);
 
-  // Clicking anywhere in the entryBox will check/uncheck the checkbox.
-  entryBox.setAttribute('for', checkbox.id);
-  entryBox.addEventListener('mousedown', entryBoxMousedown);
-
   entryBox.appendChild(time);
   var titleAndDomainWrapper = entryBox.appendChild(
       createElementWithClassName('div', 'title-and-domain'));
   titleAndDomainWrapper.appendChild(this.getTitleDOM_());
   titleAndDomainWrapper.appendChild(domain);
   if (addTitleFavicon)
     this.addFaviconToElement_(titleAndDomainWrapper);
 
   if (isMobileVersion()) {
     var removeButton = createElementWithClassName('button', 'remove-entry');
@@ skipping 390 matching lines @@
 
 /**
  * Clear the history model.
  * @private
  */
 HistoryModel.prototype.clearModel_ = function() {
   this.inFlight_ = false;  // Whether a query is inflight.
   this.searchText_ = '';
   // Whether this user is a managed user.
   this.isManagedProfile = loadTimeData.getBoolean('isManagedProfile');
+  this.deletingHistoryAllowed = loadTimeData.getBoolean('allowDeletingHistory');
+
+  // Only create checkboxes for editing entries if they can be used either to
+  // delete an entry or to block/allow it.
+  this.createEditingCheckboxes = this.deletingHistoryAllowed ||
+                                 this.isManagedProfile;
 
   // Flag to show that the results are grouped by domain or not.
   this.groupByDomain_ = false;
   // Group domains by default for managed users.
   if (this.isManagedProfile)
     this.groupByDomain_ = true;
 
   this.visits_ = [];  // Date-sorted list of visits (most recent first).
   this.nextVisitId_ = 0;
   selectionAnchor = -1;
@@ skipping 314 matching lines @@
     document.body.classList.remove('has-results');
 
   this.updateNavBar_();
 };
 
 /**
  * Enables or disables the buttons that control editing entries depending on
  * whether there are any checked boxes.
  */
 HistoryView.prototype.updateSelectionEditButtons = function() {
-  var anyChecked = document.querySelector('.entry input:checked') != null;
-  $('remove-selected').disabled = !anyChecked;
+  if (loadTimeData.getBoolean('allowDeletingHistory')) {
+    var anyChecked = document.querySelector('.entry input:checked') != null;
+    $('remove-selected').disabled = !anyChecked;
+  } else {
+    $('remove-selected').disabled = true;
+  }
   $('allow-selected').disabled = !anyChecked;
   $('block-selected').disabled = !anyChecked;
 };
 
 /**
  * Callback triggered by the backend after the manual allow or block changes
  * have been commited. Once the changes are commited the backend builds an
  * updated set of data which contains the new managed mode status and passes
  * it through this function to the client. The function takes that data and
  * updates the individiual host/URL elements with their new managed mode status.
@@ skipping 101 matching lines @@
  * @param {Element} results DOM object to which to add the elements.
  * @param {string} domain Current domain name.
  * @param {Array} domainVisits Array of visits for this domain.
  * @private
  */
 HistoryView.prototype.getGroupedVisitsDOM_ = function(
     results, domain, domainVisits) {
   // Add a new domain entry.
   var siteResults = results.appendChild(
       createElementWithClassName('li', 'site-entry'));
-  var siteDomainCheckbox =
-      createElementWithClassName('input', 'domain-checkbox');
-  siteDomainCheckbox.type = 'checkbox';
-  siteDomainCheckbox.addEventListener('click', domainCheckboxClicked);
-  siteDomainCheckbox.domain_ = domain;
+
   // Make a wrapper that will contain the arrow, the favicon and the domain.
   var siteDomainWrapper = siteResults.appendChild(
       createElementWithClassName('div', 'site-domain-wrapper'));
-  siteDomainWrapper.appendChild(siteDomainCheckbox);
+
+  if (this.model_.createEditingCheckboxes) {
+    var siteDomainCheckbox =
+        createElementWithClassName('input', 'domain-checkbox');
+
+    siteDomainCheckbox.type = 'checkbox';
+    siteDomainCheckbox.addEventListener('click', domainCheckboxClicked);
+    siteDomainCheckbox.domain_ = domain;
+
+    siteDomainWrapper.appendChild(siteDomainCheckbox);
+  }
+
   var siteArrow = siteDomainWrapper.appendChild(
       createElementWithClassName('div', 'site-domain-arrow collapse'));
   var siteDomain = siteDomainWrapper.appendChild(
       createElementWithClassName('div', 'site-domain'));
   var siteDomainLink = siteDomain.appendChild(
       createElementWithClassName('button', 'link-button'));
   siteDomainLink.addEventListener('click', function(e) { e.preventDefault(); });
   siteDomainLink.textContent = domain;
   var numberOfVisits = createElementWithClassName('span', 'number-visits');
   var domainElement = document.createElement('span');
@@ skipping 404 matching lines @@
 
   var doSearch = function(e) {
     // Disable the group by domain control when a search is active.
     $('group-by-domain').disabled = (searchField.value != '');
     historyView.setSearch(searchField.value);
 
     if (isMobileVersion())
       searchField.blur();  // Dismiss the keyboard.
   };
 
+  var mayRemoveVisits = loadTimeData.getBoolean('allowDeletingHistory');
+  $('remove-visit').disabled = !mayRemoveVisits;
+
+  if (mayRemoveVisits) {
+    $('remove-visit').addEventListener('activate', function(e) {
+      activeVisit.removeFromHistory_();
+      activeVisit = null;
+    });
+  }
+
   searchField.addEventListener('search', doSearch);
   $('search-button').addEventListener('click', doSearch);
 
-  $('remove-visit').addEventListener('activate', function(e) {
-    activeVisit.removeFromHistory();
-    activeVisit = null;
-  });
   $('more-from-site').addEventListener('activate', function(e) {
     activeVisit.showMoreFromSite_();
     activeVisit = null;
   });
 
   // Only show the controls if the command line switch is activated.
   if (loadTimeData.getBoolean('groupByDomain') ||
       loadTimeData.getBoolean('isManagedProfile')) {
     $('filter-controls').hidden = false;
   }
@@ skipping 111 matching lines @@
  */
 function openClearBrowsingData(e) {
   chrome.send('clearBrowsingData');
 }
 
 /**
  * Click handler for the 'Remove selected items' button.
  * Confirms the deletion with the user, and then deletes the selected visits.
  */
 function removeItems() {
+  if (!loadTimeData.getBoolean('allowDeletingHistory'))
+    return;
+
   var checked = $('results-display').querySelectorAll(
       '.entry-box input[type=checkbox]:checked:not([disabled])');
   var disabledItems = [];
   var toBeRemoved = [];
 
   for (var i = 0; i < checked.length; i++) {
     var checkbox = checked[i];
     var entry = findAncestorByClass(checkbox, 'entry');
     toBeRemoved.push(entry.visit);
 
@@ skipping 241 matching lines @@
   }
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });