Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 14046011: Fix wrong ASSERT (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix wrong ASSERT TBR=ager@google.com Fix building of extension sample TBR=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +2 lines, -1 line 0 comments Download
M samples/sample_extension/sample_extension.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-15 09:46:43 UTC) #1
Søren Gjesse
Committed patchset #1 manually as r21427 (presubmit successful).
7 years, 8 months ago (2013-04-15 09:56:50 UTC) #2
Mads Ager (google)
7 years, 8 months ago (2013-04-15 10:17:50 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698