Repaint windows on screen unlock.

Repaint windows on screen unlock.

D3D presents are ignored while the screen is locked, so wait for unlock and then attempt to redraw all windows.

BUG=322728
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247059

[sky, 2014-01-16 16:36:37]

+cpu as I'm not too familiar with the APIs you're using here.

https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.cc:1390:
WTSRegisterSessionNotification(hwnd(), NOTIFY_FOR_THIS_SESSION);
Docs indicate you need to unregister.

https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.h (right):

https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.h:434: void OnSessionChange(WPARAM
status_code, PWTSSESSION_NOTIFICATION session_id);
Keep alphabetical (see comment on 382).

[cpu_(ooo_6.6-7.5), 2014-01-16 18:35:08]

https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
ui/views/win/hwnd_message_handler.cc:2330: if (!input_desktop) {
son, I am not sure what you are trying to do here but I think you meant to
detect the interactive desktop

Use GetThreadDesktop and GetUserObjectInformation(UOI_IO).

Also this function as is is more expensive than its name implies, how about

bool IsInteactiveDesktop();

void HWNDMessageHandler::OnSessionChange(WPARAM status_code, ..) {
  static int count = 0;
  if (status_code == WTS_SESSION_UNLOCK)
    if (!IsInteractiveDesktop())
       PostTask(... OnSessionChange)


}

[jbauman, 2014-01-16 23:24:13]

On 2014/01/16 18:35:08, cpu wrote:
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> File ui/views/win/hwnd_message_handler.cc (right):
> 
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> ui/views/win/hwnd_message_handler.cc:2330: if (!input_desktop) {
> son, I am not sure what you are trying to do here but I think you meant to
> detect the interactive desktop

I'm trying to determine whether this has access to the interactive desktop, to
see if the workstation's locked. This is pretty much the same code as
AcceleratedPresenter::CheckDirect3DWillWork().
> 
> Use GetThreadDesktop and GetUserObjectInformation(UOI_IO).
> 
> Also this function as is is more expensive than its name implies, how about
> 
> bool IsInteactiveDesktop();
> 
> void HWNDMessageHandler::OnSessionChange(WPARAM status_code, ..) {
>   static int count = 0;
>   if (status_code == WTS_SESSION_UNLOCK)
>     if (!IsInteractiveDesktop())
>        PostTask(... OnSessionChange)
> 
> 
> }

I'd prefer not to try to use a static count (several of these could be running
at once) or a member variable, so that means I'd need a helper function that
takes an extra argument.

[jbauman, 2014-01-17 00:10:10]

On 2014/01/16 16:36:37, sky wrote:
> +cpu as I'm not too familiar with the APIs you're using here.
> 
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> File ui/views/win/hwnd_message_handler.cc (right):
> 
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> ui/views/win/hwnd_message_handler.cc:1390:
> WTSRegisterSessionNotification(hwnd(), NOTIFY_FOR_THIS_SESSION);
> Docs indicate you need to unregister.

Good point; I was basing this off of some other code that forgot to do that. Is
there a method in here that's guaranteed to be called right before the HWND is
destroyed?
> 
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> File ui/views/win/hwnd_message_handler.h (right):
> 
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> ui/views/win/hwnd_message_handler.h:434: void OnSessionChange(WPARAM
> status_code, PWTSSESSION_NOTIFICATION session_id);
> Keep alphabetical (see comment on 382).

[sky, 2014-01-17 00:38:27]

On Thu, Jan 16, 2014 at 4:10 PM,  <jbauman@chromium.org> wrote:
> On 2014/01/16 16:36:37, sky wrote:
>>
>> +cpu as I'm not too familiar with the APIs you're using here.
>
>
>
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
>>
>> File ui/views/win/hwnd_message_handler.cc (right):
>
>
>
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
>>
>> ui/views/win/hwnd_message_handler.cc:1390:
>> WTSRegisterSessionNotification(hwnd(), NOTIFY_FOR_THIS_SESSION);
>> Docs indicate you need to unregister.
>
>
> Good point; I was basing this off of some other code that forgot to do that.
> Is
> there a method in here that's guaranteed to be called right before the HWND
> is
> destroyed?

I believe you'll want OnDestroy.

  -Scott
>
>
>
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
>>
>> File ui/views/win/hwnd_message_handler.h (right):
>
>
>
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
>>
>> ui/views/win/hwnd_message_handler.h:434: void OnSessionChange(WPARAM
>> status_code, PWTSSESSION_NOTIFICATION session_id);
>> Keep alphabetical (see comment on 382).
>
>
>
>
> https://codereview.chromium.org/140453002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cpu_(ooo_6.6-7.5), 2014-01-17 02:54:04]

On 2014/01/16 23:24:13, jbauman wrote:
> On 2014/01/16 18:35:08, cpu wrote:
> >
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> > File ui/views/win/hwnd_message_handler.cc (right):
> > 
> >
>
https://codereview.chromium.org/140453002/diff/1/ui/views/win/hwnd_message_ha...
> > ui/views/win/hwnd_message_handler.cc:2330: if (!input_desktop) {
> > son, I am not sure what you are trying to do here but I think you meant to
> > detect the interactive desktop
> 
> I'm trying to determine whether this has access to the interactive desktop, to
> see if the workstation's locked. This is pretty much the same code as
> AcceleratedPresenter::CheckDirect3DWillWork().
> > 
> > Use GetThreadDesktop and GetUserObjectInformation(UOI_IO).
> > 
> > Also this function as is is more expensive than its name implies, how about
> > 
> > bool IsInteactiveDesktop();
> > 
> > void HWNDMessageHandler::OnSessionChange(WPARAM status_code, ..) {
> >   static int count = 0;
> >   if (status_code == WTS_SESSION_UNLOCK)
> >     if (!IsInteractiveDesktop())
> >        PostTask(... OnSessionChange)
> > 
> > 
> > }
> 
> I'd prefer not to try to use a static count (several of these could be running
> at once) or a member variable, so that means I'd need a helper function that
> takes an extra argument.

ok, scratch the static int idea.

[cpu_(ooo_6.6-7.5), 2014-01-19 20:52:45]

https://codereview.chromium.org/140453002/diff/100002/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/140453002/diff/100002/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:322: HDESK input_desk =
::OpenInputDesktop(0, 0, GENERIC_READ);
Opening the input desktop still has me confused. You want to know if your
process is attached to the desktop that has input right?

I see my previous idea does not work on XP, so you can use
http://www.experts-exchange.com/Programming/System/Windows__Programming/Q_235...

[jbauman, 2014-01-22 01:27:05]

PTAL. Changed the lock detection logic and added an unregister call.

[cpu_(ooo_6.6-7.5), 2014-01-23 23:01:13]

lgtm

https://codereview.chromium.org/140453002/diff/180001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/140453002/diff/180001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:333: }
if ::OpenInputDesktop fails I don't know if it is best to return true, it might
be better to return false?

[sky, 2014-01-24 00:36:07]

https://codereview.chromium.org/140453002/diff/180001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/140453002/diff/180001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:320: bool IsWorkstationLocked() {
This looks like a copy of that in idle_win. How about copying to
ui/base/win/lock_state?

[jbauman, 2014-01-24 03:22:00]

On 2014/01/24 00:36:07, sky wrote:
>
https://codereview.chromium.org/140453002/diff/180001/ui/views/win/hwnd_messa...
> File ui/views/win/hwnd_message_handler.cc (right):
> 
>
https://codereview.chromium.org/140453002/diff/180001/ui/views/win/hwnd_messa...
> ui/views/win/hwnd_message_handler.cc:320: bool IsWorkstationLocked() {
> This looks like a copy of that in idle_win. How about copying to
> ui/base/win/lock_state?

Good idea. Done.

[sky, 2014-01-24 16:35:12]

LGTM

[commit-bot: I haz the power, 2014-01-25 00:12:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/140453002/280001

[commit-bot: I haz the power, 2014-01-25 01:45:12]

Change committed as 247059