third_party/WebKit/Source/core/streams/ReadableStream.idl - Issue 1404523005: Implement author-constructible ReadableStream using V8 extras

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/streams/ReadableStream.idl

Issue 1404523005: Implement author-constructible ReadableStream using V8 extras (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update with latest imported tests from upstream Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/streams/README.md ('k') | third_party/WebKit/Source/core/streams/ReadableStream.js » ('j') | third_party/WebKit/Source/core/streams/ReadableStream.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 // This type is marked NoInterfaceObject while we work to replace it with the

	6 // V8 extras implementation. It is still used for now to implement fetch body

	7 // streams, and so we can't remove it quite yet.

	8

5 [	9 [

6 GarbageCollected,	10 GarbageCollected,

7 Exposed=(Window,Worker),	11 Exposed=(Window,Worker),

	12 NoInterfaceObject
	domenic 2015/11/11 21:56:07 Probably a better idea: use Exposed=(Window Featur Probably a better idea: use Exposed=(Window FeatureThatIsV8ExtrasNegated, Worker FeatureThatIsV8ExtrasNegated). And create such a feature. See last paragraph of https://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-Expos... Or an even better idea! Create a StableReadableStream.js V8 extra that is just empty, and remove the IDL file.
8 ] interface ReadableStream {	13 ] interface ReadableStream {

9 [CallWith=ExecutionContext, RaisesException] ReadableStreamReader getReader( );	14 [CallWith=ExecutionContext, RaisesException] ReadableStreamReader getReader( );

10 [CallWith=ScriptState] Promise<void> cancel(optional any reason);	15 [CallWith=ScriptState] Promise<void> cancel(optional any reason);

11 };	16 };

OLD	NEW