Issue 1404523004: relnote: Check QUIC handshake reject_reasons to decide whether to send

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1404523004: relnote: Check QUIC handshake reject_reasons to decide whether to send (Closed)

Created:
5 years, 2 months ago by ramant (doing other things)

Modified:
5 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Create_Quic_version_28_103943396

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: Check QUIC handshake reject_reasons to decide whether to send a REJ. No behavior change, not protected. Simplifies things a little in the server crypto code. Instead of storing both a reject_reason *and* a boolean indicating whether there was a problem, just store the reject reason and use the presence of any such reasons to decide to send a REJ. Merge internal change: 103949902 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -25 lines)			Patch
	M	net/quic/crypto/quic_crypto_server_config.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	net/quic/crypto/quic_crypto_server_config.cc	View		6 chunks	+7 lines, -23 lines	0 comments	Download

Depends on Patchset:

Issue 1398403006 Patch 1

Dependent Patchsets:

Issue 1404013002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages