[heap] inline allocation steps refactor

test/cctest/cctest.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 507 matching lines @@
   CHECK(result->SameValue(expected));
 }
 
 
 static inline void ExpectUndefined(const char* code) {
   v8::Local<v8::Value> result = CompileRun(code);
   CHECK(result->IsUndefined());
 }
 
 
-static inline void DisableInlineAllocationSteps(v8::internal::NewSpace* space) {
-  space->LowerInlineAllocationLimit(0);
-}
-
-
 static int LenFromSize(int size) {
   return (size - i::FixedArray::kHeaderSize) / i::kPointerSize;
 }
 
 
 static inline void CreatePadding(i::Heap* heap, int padding_size,
                                  i::PretenureFlag tenure) {
   const int max_number_of_objects = 20;
   v8::internal::Handle<v8::internal::FixedArray>
       big_objects[max_number_of_objects];
   i::Isolate* isolate = heap->isolate();
   int allocate_memory;
   int length;
   int free_memory = padding_size;
   if (tenure == i::TENURED) {
     int current_free_memory =
         static_cast<int>(*heap->old_space()->allocation_limit_address() -
                          *heap->old_space()->allocation_top_address());
     CHECK(padding_size <= current_free_memory || current_free_memory == 0);
   } else {
-    DisableInlineAllocationSteps(heap->new_space());
+    heap->new_space()->DisableInlineAllocationSteps();
     int current_free_memory =
         static_cast<int>(*heap->new_space()->allocation_limit_address() -
                          *heap->new_space()->allocation_top_address());
     CHECK(padding_size <= current_free_memory || current_free_memory == 0);
   }
   for (int i = 0; i < max_number_of_objects && free_memory > 0; i++) {
     if (free_memory > i::Page::kMaxRegularHeapObjectSize) {
       allocate_memory = i::Page::kMaxRegularHeapObjectSize;
       length = LenFromSize(allocate_memory);
     } else {
       allocate_memory = free_memory;
       length = LenFromSize(allocate_memory);
       if (length <= 0) {
         // Not enough room to create another fixed array. Let's create a filler.
         heap->CreateFillerObjectAt(*heap->old_space()->allocation_top_address(),
                                    free_memory);
         break;
       }
     }
     big_objects[i] = isolate->factory()->NewFixedArray(length, tenure);
     CHECK((tenure == i::NOT_TENURED && heap->InNewSpace(*big_objects[i])) ||
           (tenure == i::TENURED && heap->InOldSpace(*big_objects[i])));
     free_memory -= allocate_memory;
   }
 }
 
 
 // Helper function that simulates a full new-space in the heap.
 static inline bool FillUpOnePage(v8::internal::NewSpace* space) {
-  DisableInlineAllocationSteps(space);
+  space->DisableInlineAllocationSteps();
   int space_remaining = static_cast<int>(*space->allocation_limit_address() -
                                          *space->allocation_top_address());
   if (space_remaining == 0) return false;
   CreatePadding(space->heap(), space_remaining, i::NOT_TENURED);
   return true;
 }
 
 
 // Helper function that simulates a fill new-space in the heap.
 static inline void AllocateAllButNBytes(v8::internal::NewSpace* space,
                                         int extra_bytes) {
-  DisableInlineAllocationSteps(space);
+  space->DisableInlineAllocationSteps();
   int space_remaining = static_cast<int>(*space->allocation_limit_address() -
                                          *space->allocation_top_address());
   CHECK(space_remaining >= extra_bytes);
   int new_linear_size = space_remaining - extra_bytes;
   if (new_linear_size == 0) return;
   CreatePadding(space->heap(), new_linear_size, i::NOT_TENURED);
 }
 
 
 static inline void FillCurrentPage(v8::internal::NewSpace* space) {
@@ skipping 81 matching lines @@
   HandleAndZoneScope() {}
 
   // Prefixing the below with main_ reduces a lot of naming clashes.
   i::Zone* main_zone() { return &main_zone_; }
 
  private:
   i::Zone main_zone_;
 };
 
 #endif  // ifndef CCTEST_H_