[heap] inline allocation steps refactor

src/heap/spaces.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_SPACES_H_
 #define V8_HEAP_SPACES_H_
 
 #include "src/allocation.h"
 #include "src/atomic-utils.h"
 #include "src/base/atomicops.h"
@@ skipping 2443 matching lines @@
  private:
   NewSpacePage* prev_page_;  // Previous page returned.
   // Next page that will be returned.  Cached here so that we can use this
   // iterator for operations that deallocate pages.
   NewSpacePage* next_page_;
   // Last page returned.
   NewSpacePage* last_page_;
 };
 
 
+class InlineAllocationObserver {

[Hannes Payer (out of office), 2015/10/16 15:31:17]

This class needs a description and a few comments. And since it is
unit-testable, can we add a few unit tests.

[ofrobots, 2015/10/16 21:26:35]

Done.

+ public:
+  typedef void (*callback_t)(int bytes_allocated, void* arg);
+
+  InlineAllocationObserver(intptr_t step_size, callback_t callback,
+                           void* callback_arg)
+      : step_size_(step_size),
+        callback_(callback),
+        callback_arg_(callback_arg),
+        bytes_to_next_step_(step_size) {
+    DCHECK(step_size > 0);
+  }
+
+  InlineAllocationObserver(const InlineAllocationObserver&) = default;
+  InlineAllocationObserver& operator=(const InlineAllocationObserver&) =
+      default;
+
+  void step(int bytes_allocated) {
+    bytes_to_next_step_ -= bytes_allocated;
+    if (bytes_to_next_step_ <= 0) {
+      callback_(static_cast<int>(step_size_ - bytes_to_next_step_),
+                callback_arg_);
+      bytes_to_next_step_ = step_size_;
+    }
+  }
+
+  intptr_t step_size() const { return step_size_; }
+  callback_t callback() const { return callback_; }
+
+ private:
+  intptr_t step_size_;
+  callback_t callback_;
+  void* callback_arg_;
+  intptr_t bytes_to_next_step_;
+};
+
 // -----------------------------------------------------------------------------
 // The young generation space.
 //
 // The new space consists of a contiguous pair of semispaces.  It simply
 // forwards most functions to the appropriate semispace.
 
 class NewSpace : public Space {
  public:
   // Constructor.
   explicit NewSpace(Heap* heap)
@@ skipping 168 matching lines @@
   MUST_USE_RESULT INLINE(
       AllocationResult AllocateRawUnaligned(int size_in_bytes));
 
   MUST_USE_RESULT INLINE(AllocationResult AllocateRaw(
       int size_in_bytes, AllocationAlignment alignment));
 
   // Reset the allocation pointer to the beginning of the active semispace.
   void ResetAllocationInfo();
 
   void UpdateInlineAllocationLimit(int size_in_bytes);
-  void LowerInlineAllocationLimit(intptr_t step) {
-    inline_allocation_limit_step_ = step;
+
+  void AddInlineAllocationObserver(
+      intptr_t step_size, InlineAllocationObserver::callback_t callback,
+      void* callback_arg);
+  void RemoveInlineAllocationObserver(
+      InlineAllocationObserver::callback_t callback);
+  void DisableInlineAllocationSteps() {
+    inline_allocation_limit_step_ = 0;
+    top_on_previous_step_ = 0;
     UpdateInlineAllocationLimit(0);
-    top_on_previous_step_ = step ? allocation_info_.top() : 0;
   }
 
   // Get the extent of the inactive semispace (for use as a marking stack,
   // or to zap it). Notice: space-addresses are not necessarily on the
   // same page, so FromSpaceStart() might be above FromSpaceEnd().
   Address FromSpacePageLow() { return from_space_.page_low(); }
   Address FromSpacePageHigh() { return from_space_.page_high(); }
   Address FromSpaceStart() { return from_space_.space_start(); }
   Address FromSpaceEnd() { return from_space_.space_end(); }
 
@@ skipping 55 matching lines @@
   }
 
   bool IsFromSpaceCommitted() { return from_space_.is_committed(); }
 
   SemiSpace* active_space() { return &to_space_; }
 
  private:
   // Update allocation info to match the current to-space page.
   void UpdateAllocationInfo();
 
+  void UpdateInlineAllocationLimitStep();
+
   Address chunk_base_;
   uintptr_t chunk_size_;
 
   // The semispaces.
   SemiSpace to_space_;
   SemiSpace from_space_;
   base::VirtualMemory reservation_;
   int pages_used_;
 
   // Start address and bit mask for containment testing.
   Address start_;
   uintptr_t address_mask_;
   uintptr_t object_mask_;
   uintptr_t object_expected_;
 
   // Allocation pointer and limit for normal allocation and allocation during
   // mark-compact collection.
   AllocationInfo allocation_info_;
 
-  // When incremental marking is active we will set allocation_info_.limit
-  // to be lower than actual limit and then will gradually increase it
-  // in steps to guarantee that we do incremental marking steps even
-  // when all allocation is performed from inlined generated code.
+  // When inline allocation stepping is active, either because of incremental
+  // marking or because of idle scavenge, we 'interrupt' inline allocation every
+  // once in a while. This is done by setting allocation_info_.limit to be lower
+  // than the actual limit and and increasing it in steps to guarantee that the
+  // observers are notified periodically.
   intptr_t inline_allocation_limit_step_;
+  List<InlineAllocationObserver> inline_allocation_observers_;
 
   Address top_on_previous_step_;
 
   HistogramInfo* allocated_histogram_;
   HistogramInfo* promoted_histogram_;
 
   bool EnsureAllocation(int size_in_bytes, AllocationAlignment alignment);
 
   // If we are doing inline allocation in steps, this method performs the 'step'
-  // operation. Right now incremental marking is the only consumer of inline
-  // allocation steps. top is the memory address of the bump pointer at the last
+  // operation. top is the memory address of the bump pointer at the last
   // inline allocation (i.e. it determines the numbers of bytes actually
   // allocated since the last step.) new_top is the address of the bump pointer
   // where the next byte is going to be allocated from. top and new_top may be
   // different when we cross a page boundary or reset the space.
   void InlineAllocationStep(Address top, Address new_top);
 
   friend class SemiSpaceIterator;
 };
 
 // -----------------------------------------------------------------------------
@@ skipping 233 matching lines @@
     count = 0;
   }
   // Must be small, since an iteration is used for lookup.
   static const int kMaxComments = 64;
 };
 #endif
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_SPACES_H_