Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404483002: post-commit fixes to applyFilter CL (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

post-commit fixes to applyFilter CL BUG=skia: Committed: https://skia.googlesource.com/skia/+/d82bc7b90ab0a88d6fb401994f3763d3057ab6e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M include/core/SkImage.h View 1 chunk +4 lines, -4 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
reed1
5 years, 2 months ago (2015-10-12 18:47:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404483002/1
5 years, 2 months ago (2015-10-12 18:49:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1940) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 2 months ago (2015-10-12 18:49:53 UTC) #6
robertphillips
lgtm % all that red
5 years, 2 months ago (2015-10-12 19:03:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404483002/1
5 years, 2 months ago (2015-10-12 19:26:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1943) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 2 months ago (2015-10-12 19:27:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404483002/1
5 years, 2 months ago (2015-10-12 19:31:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/3650)
5 years, 2 months ago (2015-10-12 19:32:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404483002/1
5 years, 2 months ago (2015-10-12 20:13:38 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 20:17:29 UTC) #19
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d82bc7b90ab0a88d6fb401994f3763d3057ab6e7

Powered by Google App Engine
This is Rietveld 408576698