Add _TypedDataBuffer.addRange.

test/typed_buffers_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Tests typed-data buffer classes.
 
 import "dart:typed_data";
 
 import "package:test/test.dart";
 import "package:typed_data/typed_buffers.dart";
@@ skipping 17 matching lines @@
 
   testInt32x4Buffer(intSamples);
 
   List roundedFloatSamples = floatSamples.map(roundToFloat).toList();
   testFloatBuffer(32, roundedFloatSamples,
                   () => new Float32Buffer(),
                   roundToFloat);
   testFloatBuffer(64, doubleSamples, () => new Float64Buffer(), (x) => x);
 
   testFloat32x4Buffer(roundedFloatSamples);
+
+  group("addAll", () {
+    for (var type in ['list', 'iterable']) {
+      group("with a${type == 'list' ? '' : 'n'} $type", () {

[Lasse Reichstein Nielsen, 2015/10/15 10:58:25]

You could just make the string "a list" and "an iterable".

[nweiz, 2015/10/15 20:14:10]

Done.

+        var source;
+        var buffer;
+        setUp(() {
+          source = [1, 2, 3, 4, 5];
+          if (type == 'iterable') source = source.reversed.toList().reversed;
+          buffer = new Uint8Buffer();
+        });
+
+        test("adds values to the buffer", () {
+          buffer.addAll(source, 1, 4);
+          expect(buffer, equals([2, 3, 4]));
+
+          buffer.addAll(source, 4);
+          expect(buffer, equals([2, 3, 4, 5]));
+
+          buffer.addAll(source, 0, 1);
+          expect(buffer, equals([2, 3, 4, 5, 1]));
+        });
+
+        test("does nothing for empty slices", () {
+          buffer.addAll([6, 7, 8, 9, 10]);
+
+          buffer.addAll(source, 0, 0);
+          expect(buffer, equals([6, 7, 8, 9, 10]));
+
+          buffer.addAll(source, 3, 3);
+          expect(buffer, equals([6, 7, 8, 9, 10]));
+
+          buffer.addAll(source, 5);
+          expect(buffer, equals([6, 7, 8, 9, 10]));
+        });
+
+        test("throws errors for invalid start and end", () {
+          expect(() => buffer.addAll(source, -1), throwsRangeError);
+          expect(() => buffer.addAll(source, 10), throwsRangeError);
+          expect(() => buffer.addAll(source, 3, 2), throwsRangeError);
+          expect(() => buffer.addAll(source, 3, 10), throwsRangeError);
+          expect(() => buffer.addAll(source, 3, -1), throwsRangeError);

[Lasse Reichstein Nielsen, 2015/10/15 10:58:25]

This is where I think #2 and #4 should not be errors.

[nweiz, 2015/10/15 20:14:10]

AFAICT this would be inconsistent with existing methods.

[Lasse Reichstein Nielsen, 2015/10/20 08:09:49]

Only accidentally. Ranges on iterables should generally be assumed to be
equivalent to .take+.skip.

+        });
+      });
+    }
+  });
 }
 
 double roundToFloat(double value) {
   return (new Float32List(1)..[0] = value)[0];
 }
 
 typedef int Rounder(int value);
 
 Rounder roundUint(bits) {
   int halfbits = (1 << (bits ~/ 2)) - 1;
@@ skipping 369 matching lines @@
   bool matches(item, Map matchState) {
     if (item is! Int32x4) return false;
     Int32x4 value = item;
     return result.x == value.x && result.y == value.y &&
            result.z == value.z && result.w == value.w;
   }
 
   Description describe(Description description) =>
       description.add('Int32x4.==');
 }