ui: Cleanup ui::Layer

ui: Cleanup ui::Layer

* Add & update description of some member functions and variables.
* Remove unused variable - layer_updated_externally_.
* Remove redundant function calls - SetXXXImmediately().
    - Immediate setting is done by default animator.

R=danakj@chromium.org
BUG=NONE
TEST=compositor_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245357

[simonhong, 2014-01-16 02:00:21]

Dear danakj,
Please take a look.

[danakj, 2014-01-16 19:48:29]

LGTM w/ a couple comments

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h
File ui/compositor/layer.h (right):

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h#newcod...
ui/compositor/layer.h:287: // |cc_layer_| to update dirty rect.
// Uses damaged rectangles recorded in |damaged_region_| to invalidate the
|cc_layer_|.

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h#newcod...
ui/compositor/layer.h:292: // Suppresses painting the content by deleting
|delegate_|.
This disconnects the delegate - it doesn't delete it.

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h#newcod...
ui/compositor/layer.h:418: // See SetForceRenderSurface() for more details.
Is this really needed?

[simonhong, 2014-01-16 20:59:59]

Dear danakj,
Thank you for review!

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h
File ui/compositor/layer.h (right):

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h#newcod...
ui/compositor/layer.h:287: // |cc_layer_| to update dirty rect.
On 2014/01/16 19:48:29, danakj wrote:
> // Uses damaged rectangles recorded in |damaged_region_| to invalidate the
> |cc_layer_|.

Done.

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h#newcod...
ui/compositor/layer.h:292: // Suppresses painting the content by deleting
|delegate_|.
On 2014/01/16 19:48:29, danakj wrote:
> This disconnects the delegate - it doesn't delete it.

Modified to disconnecting |delegate_|.

https://codereview.chromium.org/140443002/diff/1/ui/compositor/layer.h#newcod...
ui/compositor/layer.h:418: // See SetForceRenderSurface() for more details.
On 2014/01/16 19:48:29, danakj wrote:
> Is this really needed?

No.. I think it's redundant. Removed.

[commit-bot: I haz the power, 2014-01-16 21:05:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simonhong@chromium.org/140443002/70001

[commit-bot: I haz the power, 2014-01-16 22:44:03]

Change committed as 245357