Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java

Issue 1404423006: [Cronet] Do not follow Http <-> Https redirects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/test/assets/test/redirect_invalid_scheme.html.mock-http-headers ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
index 92cd8c359d415c2a388831ddbf6b05909286e39c..5fd501d0e36015382dcb4391ff8db8c99483a489 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java
@@ -780,6 +780,21 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
@CompareDefaultWithCronet
+ // Tests that redirects across the HTTP and HTTPS boundary are not followed.
+ public void testDoNotFollowRedirectsIfSchemesDontMatch() throws Exception {
+ URL url = new URL(NativeTestServer.getFileURL("/redirect_invalid_scheme.html"));
+ HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+ connection.setInstanceFollowRedirects(true);
+ assertEquals(302, connection.getResponseCode());
+ assertEquals("Found", connection.getResponseMessage());
+ // Redirect is not followed, but the url is updated to the Location header.
+ assertEquals("https://127.0.0.1:8000/success.txt", connection.getURL().toString());
+ connection.disconnect();
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ @CompareDefaultWithCronet
public void testGetResponseHeadersAsMap() throws Exception {
URL url = new URL(NativeTestServer.getFileURL("/success.txt"));
HttpURLConnection connection =
« no previous file with comments | « components/cronet/android/test/assets/test/redirect_invalid_scheme.html.mock-http-headers ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698