Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: runtime/lib/mirrors.cc

Issue 14044007: Add synchronous mirror API. Resurrects invoke, apply, newInstance, getField and setField as synchro… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
===================================================================
--- runtime/lib/mirrors.cc (revision 21243)
+++ runtime/lib/mirrors.cc (working copy)
@@ -198,6 +198,22 @@
return Dart_True();
}
+static Dart_Handle UnpackLocalArgList(Dart_Handle arg_list,
+ GrowableArray<Dart_Handle>* arg_array) {
srdjan 2013/04/11 21:29:43 Strange formatting
+ intptr_t len = 0;
+ Dart_Handle result = Dart_ListLength(arg_list, &len);
+ if (Dart_IsError(result)) {
+ return result;
+ }
+ for (intptr_t i = 0; i < len; i++) {
+ Dart_Handle arg = Dart_ListGetAt(arg_list, i);
+ if (Dart_IsError(arg)) {
+ return arg;
+ }
+ arg_array->Add(arg);
+ }
+ return Dart_True();
+ }
srdjan 2013/04/11 21:29:43 ditto.
static Dart_Handle CreateLazyMirror(Dart_Handle target);
@@ -1051,7 +1067,7 @@
}
-void NATIVE_ENTRY_FUNCTION(LocalObjectMirrorImpl_invoke)(
+void NATIVE_ENTRY_FUNCTION(LocalObjectMirrorImpl_invokeAsync)(
Dart_NativeArguments args) {
Dart_EnterScope();
Dart_Handle mirror = Dart_GetNativeArgument(args, 0);
@@ -1105,7 +1121,7 @@
}
-void NATIVE_ENTRY_FUNCTION(LocalObjectMirrorImpl_setField)(
+void NATIVE_ENTRY_FUNCTION(LocalObjectMirrorImpl_setFieldAsync)(
Dart_NativeArguments args) {
Dart_EnterScope();
Dart_Handle mirror = Dart_GetNativeArgument(args, 0);
@@ -1134,7 +1150,7 @@
}
-void NATIVE_ENTRY_FUNCTION(LocalClosureMirrorImpl_apply)(
+void NATIVE_ENTRY_FUNCTION(LocalClosureMirrorImpl_applyAsync)(
Dart_NativeArguments args) {
Dart_EnterScope();
Dart_Handle mirror = Dart_GetNativeArgument(args, 0);
@@ -1164,7 +1180,7 @@
}
-void NATIVE_ENTRY_FUNCTION(LocalClassMirrorImpl_invokeConstructor)(
+void NATIVE_ENTRY_FUNCTION(LocalClassMirrorImpl_invokeConstructorAsync)(
Dart_NativeArguments args) {
Dart_EnterScope();
Dart_Handle klass_mirror = Dart_GetNativeArgument(args, 0);
@@ -1196,7 +1212,127 @@
Dart_ExitScope();
}
+void NATIVE_ENTRY_FUNCTION(LocalObjectMirrorImpl_invoke)(
+ Dart_NativeArguments args) {
+ Dart_EnterScope();
+ Dart_Handle mirror = Dart_GetNativeArgument(args, 0);
+ Dart_Handle member = Dart_GetNativeArgument(args, 1);
+ Dart_Handle wrapped_invoke_args = Dart_GetNativeArgument(args, 2);
+
+ Dart_Handle reflectee = UnwrapMirror(mirror);
+ GrowableArray<Dart_Handle> invoke_args;
+ Dart_Handle result = UnpackLocalArgList(wrapped_invoke_args, &invoke_args);
+ if (Dart_IsError(result)) {
+ Dart_PropagateError(result);
+ }
+ result =
+ Dart_Invoke(reflectee, member, invoke_args.length(), invoke_args.data());
+ if (Dart_IsError(result)) {
+ // Instead of propagating the error from an invoke directly, we
+ // provide reflective access to the error.
+ Dart_PropagateError(CreateMirroredError(result));
+ }
+
+ Dart_Handle wrapped_result = CreateInstanceMirror(result);
+ if (Dart_IsError(wrapped_result)) {
+ Dart_PropagateError(wrapped_result);
+ }
+ Dart_SetReturnValue(args, wrapped_result);
+ Dart_ExitScope();
+}
+
+void NATIVE_ENTRY_FUNCTION(LocalObjectMirrorImpl_setField)(
+ Dart_NativeArguments args) {
+ Dart_EnterScope();
+ Dart_Handle mirror = Dart_GetNativeArgument(args, 0);
+ Dart_Handle fieldName = Dart_GetNativeArgument(args, 1);
+
+ Dart_Handle set_arg = Dart_GetNativeArgument(args, 2);
+
+ Dart_Handle reflectee = UnwrapMirror(mirror);
+ if (Dart_IsError(set_arg)) {
+ Dart_PropagateError(set_arg);
+ }
+ Dart_Handle result = Dart_SetField(reflectee, fieldName, set_arg);
+ if (Dart_IsError(result)) {
+ // Instead of propagating the error from a SetField directly, we
+ // provide reflective access to the error.
+ Dart_PropagateError(CreateMirroredError(result));
+ }
+
+ Dart_Handle wrapped_result = CreateInstanceMirror(result);
+ if (Dart_IsError(wrapped_result)) {
+ Dart_PropagateError(wrapped_result);
+ }
+ Dart_SetReturnValue(args, wrapped_result);
+ Dart_ExitScope();
+}
+
+
+void NATIVE_ENTRY_FUNCTION(LocalClosureMirrorImpl_apply)(
+ Dart_NativeArguments args) {
+ Dart_EnterScope();
+ Dart_Handle mirror = Dart_GetNativeArgument(args, 0);
+
+ Dart_Handle wrapped_invoke_args = Dart_GetNativeArgument(args, 1);
+
+ Dart_Handle reflectee = UnwrapMirror(mirror);
+ GrowableArray<Dart_Handle> invoke_args;
+ Dart_Handle result = UnpackLocalArgList(wrapped_invoke_args, &invoke_args);
+ if (Dart_IsError(result)) {
+ Dart_PropagateError(result);
+ }
+ result =
+ Dart_InvokeClosure(reflectee, invoke_args.length(), invoke_args.data());
+ if (Dart_IsError(result)) {
+ // Instead of propagating the error from an apply directly, we
+ // provide reflective access to the error.
+ Dart_PropagateError(CreateMirroredError(result));
+ }
+
+ Dart_Handle wrapped_result = CreateInstanceMirror(result);
+ if (Dart_IsError(wrapped_result)) {
+ Dart_PropagateError(wrapped_result);
+ }
+ Dart_SetReturnValue(args, wrapped_result);
+ Dart_ExitScope();
+}
+
+
+void NATIVE_ENTRY_FUNCTION(LocalClassMirrorImpl_invokeConstructor)(
+ Dart_NativeArguments args) {
+ Dart_EnterScope();
+ Dart_Handle klass_mirror = Dart_GetNativeArgument(args, 0);
+ Dart_Handle constructor_name = Dart_GetNativeArgument(args, 1);
+
+ Dart_Handle wrapped_invoke_args = Dart_GetNativeArgument(args, 2);
+
+ Dart_Handle klass = UnwrapMirror(klass_mirror);
+ GrowableArray<Dart_Handle> invoke_args;
+ Dart_Handle result = UnpackLocalArgList(wrapped_invoke_args, &invoke_args);
+ if (Dart_IsError(result)) {
+ Dart_PropagateError(result);
+ }
+ result = Dart_New(klass,
+ constructor_name,
+ invoke_args.length(),
+ invoke_args.data());
+ if (Dart_IsError(result)) {
+ // Instead of propagating the error from an invoke directly, we
+ // provide reflective access to the error.
+ Dart_PropagateError(CreateMirroredError(result));
+ }
+
+ Dart_Handle wrapped_result = CreateInstanceMirror(result);
+ if (Dart_IsError(wrapped_result)) {
+ Dart_PropagateError(wrapped_result);
+ }
+ Dart_SetReturnValue(args, wrapped_result);
+ Dart_ExitScope();
+}
+
+
void HandleMirrorsMessage(Isolate* isolate,
Dart_Port reply_port,
const Instance& message) {
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698