Add synchronous mirror API. Resurrects invoke, apply, newInstance, getField and setField as synchro…

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
   return (value == null || value is num || value is String || value is bool);
 }
@@ skipping 121 matching lines @@
   // For now, all VMObjects hold a VMReference.  We could consider
   // storing the Object reference itself here if the object is a Dart
   // language objects (except for objects of type VMReference, of
   // course).
   VMReference _reference;
 }
 
 abstract class _LocalObjectMirrorImpl extends _LocalVMObjectMirrorImpl
     implements ObjectMirror {
   _LocalObjectMirrorImpl(ref) : super(ref) {}
+
+InstanceMirror invoke(String memberName,
+                      List positionalArguments,
+                      [Map<String,dynamic> namedArguments]) {
+    if (namedArguments != null) {
+      throw new UnimplementedError(
+          'named argument support is not implemented');
+    }
+    return _invoke(this, memberName, positionalArguments); // needs to be distinct for sync calls

[Ivan Posva, 2013/04/12 21:15:26]

Long lines.

+  }
+
+  InstanceMirror getField(String fieldName) {
+    return _getField(this, fieldName); // needs to be distinct for sync calls
+  }
+
+  InstanceMirror setField(String fieldName, Object arg) {
+    return _setField(this, fieldName, arg); // needs to be distinct for sync calls
+  }
+
+
   
 Future<InstanceMirror> invokeAsync(String memberName,

[Ivan Posva, 2013/04/12 21:15:26]

Please indent this appropriately.

                                    List positionalArguments,
                                    [Map<String,dynamic> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _validateArgument(i, arg);
     }
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(
-          _invoke(this, memberName, positionalArguments));
+          _invokeAsync(this, memberName, positionalArguments));
     } catch (exception, s) {
       completer.completeError(exception, s);
     }
     return completer.future;
   }
 
   Future<InstanceMirror> getFieldAsync(String fieldName) {
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(_getField(this, fieldName));
     } catch (exception, s) {
       completer.completeError(exception, s);
     }
     return completer.future;
   }
 
   Future<InstanceMirror> setFieldAsync(String fieldName, Object arg) {
     _validateArgument(0, arg);
 
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
-      completer.complete(_setField(this, fieldName, arg));
+      completer.complete(_setFieldAsync(this, fieldName, arg));
     } catch (exception, s) {
       completer.completeError(exception, s);
     }
     return completer.future;
   }
 
   static _validateArgument(int i, Object arg)
   {
     if (arg is Mirror) {
         if (arg is! InstanceMirror) {
           throw new MirrorException(
               'positional argument $i ($arg) was not an InstanceMirror');
         }
       } else if (!_isSimpleValue(arg)) {
         throw new MirrorException(
             'positional argument $i ($arg) was not a simple value');
       }
   }
 
   static _invoke(ref, memberName, positionalArguments)
       native 'LocalObjectMirrorImpl_invoke';
 
-  static _getField(ref, fieldName)
+  static _getField(ref, fieldName) // same for sync and async versions
       native 'LocalObjectMirrorImpl_getField';
 
   static _setField(ref, fieldName, value)
       native 'LocalObjectMirrorImpl_setField';
+
+  static _invokeAsync(ref, memberName, positionalArguments)
+      native 'LocalObjectMirrorImpl_invokeAsync';
+
+  static _setFieldAsync(ref, fieldName, value)
+      native 'LocalObjectMirrorImpl_setFieldAsync';
 }
 
 // Prints a string as it might appear in dart program text.
 // TODO(turnidge): Consider truncating.
 String _dartEscape(String str) {
   bool isNice(int code) => (code >= 32 && code <= 126);
 
   StringBuffer buf = new StringBuffer();
   for (int i = 0; i < str.length; i++) {
     var input = str[i];
@@ skipping 78 matching lines @@
                           reflectee,
                           this.function) : super(ref, type, reflectee) {}
 
   final MethodMirror function;
 
   String get source {
     throw new UnimplementedError(
         'ClosureMirror.source is not implemented');
   }
 
+  InstanceMirror apply(List<Object> positionalArguments,
+                       [Map<String,Object> namedArguments]) {
+    if (namedArguments != null) {
+      throw new UnimplementedError(
+          'named argument support is not implemented');
+    }
+    return _apply(this, positionalArguments);
+  }
+
   Future<InstanceMirror> applyAsync(List<Object> positionalArguments,
                                     [Map<String,Object> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _LocalObjectMirrorImpl._validateArgument(i, arg);
     }
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(
-          _apply(this, positionalArguments));
+          _applyAsync(this, positionalArguments));
     } catch (exception) {
       completer.completeError(exception);
     }
     return completer.future;
   }
 
   Future<InstanceMirror> findInContext(String name) {
     throw new UnimplementedError(
         'ClosureMirror.findInContext() is not implemented');
   }
 
   static _apply(ref, positionalArguments)
       native 'LocalClosureMirrorImpl_apply';
+
+  static _applyAsync(ref, positionalArguments)
+      native 'LocalClosureMirrorImpl_applyAsync';
 }
 
 class _LazyTypeMirror {
   _LazyTypeMirror(this.libraryName, this.typeName) {}
 
   TypeMirror resolve(MirrorSystem mirrors) {
     if (libraryName == null) {
       if (typeName == 'dynamic') {
         return mirrors.dynamicType;
       } else if (typeName == 'void') {
@@ skipping 148 matching lines @@
         'ClassMirror.isOriginalDeclaration is not implemented');
   }
 
   ClassMirror get genericDeclaration {
     throw new UnimplementedError(
         'ClassMirror.originalDeclaration is not implemented');
   }
 
   String toString() => "ClassMirror on '$simpleName'";
 
+  InstanceMirror apply(List<Object> positionalArguments,
+                       [Map<String,Object> namedArguments]) {
+    if (namedArguments != null) {
+      throw new UnimplementedError(
+          'named argument support is not implemented');
+    }
+    return _apply(this, positionalArguments);
+  }
+
+  InstanceMirror newInstance(String constructorName,
+                             List positionalArguments,
+                             [Map<String,dynamic> namedArguments]) {
+    if (namedArguments != null) {
+      throw new UnimplementedError(
+          'named argument support is not implemented');
+    }
+    return _invokeConstructor(this, constructorName, positionalArguments);
+  }
+
   Future<InstanceMirror> newInstanceAsync(String constructorName,
                                           List positionalArguments,
                                           [Map<String,dynamic> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _LocalObjectMirrorImpl._validateArgument(i, arg);
     }
     Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
       completer.complete(
-          _invokeConstructor(this, constructorName, positionalArguments));
+          _invokeConstructorAsync(this, constructorName, positionalArguments));
     } catch (exception) {
       completer.completeError(exception);
     }
     return completer.future;
   }
 
   static _invokeConstructor(ref, constructorName, positionalArguments)
       native 'LocalClassMirrorImpl_invokeConstructor';
+
+  static _invokeConstructorAsync(ref, constructorName, positionalArguments)
+      native 'LocalClassMirrorImpl_invokeConstructorAsync';
 }
 
 class _LazyFunctionTypeMirror {
   _LazyFunctionTypeMirror(this.returnType, this.parameters) {}
 
   ClassMirror resolve(MirrorSystem mirrors) {
     return mirrors._lookupFunctionTypeMirror(returnType.resolve(mirrors),
                                              parameters);
   }
 
@@ skipping 430 matching lines @@
 
   // Creates a new local mirror for some Object.
   static InstanceMirror reflect(Object reflectee) {
     return makeLocalInstanceMirror(reflectee);
   }
 
   static ClassMirror reflectClass(Type reflectee) {
     throw new UnimplementedError('reflectClass is not implemented');
   }
 }