Issue 1404353007: Completion exceptions are never fatal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1404353007: Completion exceptions are never fatal. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Completion exceptions are never fatal. Actually only some methods of the 'edit' domain are potentially fatal. Alternative solutions: 1. Don't make anything fatal. 2. Add areExceptionsFatal to RequestHandler. 3. Let every domain to decide whether exceptions in some method or none of them are fatal. R=brianwilkerson@google.com, danrubel@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4e5938f373cc47cb6266c7b76af1c913fbcd47bc

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	pkg/analysis_server/lib/src/domain_completion.dart	View		2 chunks	+14 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 2 months ago (2015-10-22 03:27:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e5938f373cc47cb6266c7b76af1c913fbcd47bc (presubmit successful).