Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1404343004: GN: Suppress MSVC "const should be initialized" warning in NaCl code (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Suppress MSVC "const should be initialized" warning in NaCl code Some of the NaCl code uses a perfectly sensible code pattern that the MSVC compiler misunderstands and issues a warning for. Suppress that warning for NaCl code. BUG=512869 R=dpranke@chromium.org Committed: https://crrev.com/8379ac5916cb0ef3832c1369fca6d547ed07673b Cr-Commit-Position: refs/heads/master@{#356712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M build/config/nacl/BUILD.gn View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Roland McGrath
5 years, 1 month ago (2015-10-29 00:01:25 UTC) #1
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-29 00:08:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404343004/1
5 years, 1 month ago (2015-10-29 00:22:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 00:56:20 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8379ac5916cb0ef3832c1369fca6d547ed07673b Cr-Commit-Position: refs/heads/master@{#356712}
5 years, 1 month ago (2015-10-29 00:57:52 UTC) #6
Peter Kasting
5 years, 1 month ago (2015-10-29 00:57:59 UTC) #8
Message was sent while issue was closed.
Is this how we deal with things on the GYP build?

As the resident Windows warning re-enabler, I'm always keen to avoid adding more
suppressions, but especially if they differ between GYP and GN.

Powered by Google App Engine
This is Rietveld 408576698