Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: extensions/common/manifest_constants.cc

Issue 140433003: tab capture: Change the permissions for tabs.captureVisibleTab(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index 9e59b441eee7723886b9fb3cd9c203e131f081fd..bc73c667cb6bab0b464093240a594617b3dadbe4 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -220,6 +220,13 @@ const char kLaunchContainerWindow[] = "window";
// cross-platform.
namespace manifest_errors {
+const char kActiveTabPermissionNotGranted[] =
+ "This extension has the 'activeTab' permission, however it has not been "
+ "granted that permission by the user for the current tab.";
not at google - send to devlin 2014/01/21 21:44:21 The terminology we've been using for "active tab g
sadrul 2014/01/23 20:11:14 Done.
+
+const char kAllURLOrActiveTabNeeded[] =
+ "This extension needs at least one of '<all_urls>' and 'activeTab' "
not at google - send to devlin 2014/01/21 21:44:21 Juts "Either the '<all_urls>' or 'activeTab' permi
sadrul 2014/01/23 20:11:14 Done.
+ "permissions.";
const char kAppsNotEnabled[] =
"Apps are not enabled.";
const char kBackgroundPermissionNeeded[] =

Powered by Google App Engine
This is Rietveld 408576698