tab capture: Change the permissions for tabs.captureVisibleTab().

chrome/browser/extensions/active_tab_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/values.h"
@@ skipping 39 matching lines @@
   return ExtensionBuilder()
       .SetManifest(DictionaryBuilder()
           .Set("name", "Extension with ID " + id)
           .Set("version", "1.0")
           .Set("manifest_version", 2)
           .Set("permissions", permissions))
       .SetID(id)
       .Build();
 }
 
+enum PermittedFeature {
+  PERMITTED_NONE,
+  PERMITTED_SCRIPT_ONLY,
+  PERMITTED_CAPTURE_ONLY,
+  PERMITTED_BOTH
+};
+
 class ActiveTabTest : public ChromeRenderViewHostTestHarness {
  protected:
   ActiveTabTest()
       : current_channel(chrome::VersionInfo::CHANNEL_DEV),
         extension(CreateTestExtension("deadbeef", true, false)),
         another_extension(CreateTestExtension("feedbeef", true, false)),
         extension_without_active_tab(CreateTestExtension("badbeef",
                                                          false,
                                                          false)),
         extension_with_tab_capture(CreateTestExtension("cafebeef",
                                                        true,
                                                        true)) {}
 
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
     TabHelper::CreateForWebContents(web_contents());
   }
 
   int tab_id() {
     return SessionID::IdForTab(web_contents());
   }
 
   ActiveTabPermissionGranter* active_tab_permission_granter() {
     return extensions::TabHelper::FromWebContents(web_contents())->
         active_tab_permission_granter();
   }
 
   bool IsAllowed(const scoped_refptr<const Extension>& extension,
                  const GURL& url) {
-    return IsAllowed(extension, url, tab_id());
+    return IsAllowed(extension, url, PERMITTED_BOTH, tab_id());
   }
 
   bool IsAllowed(const scoped_refptr<const Extension>& extension,
                  const GURL& url,
+                 PermittedFeature feature) {
+    return IsAllowed(extension, url, feature, tab_id());
+  }
+
+  bool IsAllowed(const scoped_refptr<const Extension>& extension,
+                 const GURL& url,
+                 PermittedFeature feature,
                  int tab_id) {
-    return PermissionsData::CanExecuteScriptOnPage(
-               extension.get(), url, url, tab_id, NULL, -1, NULL) &&
-           PermissionsData::CanCaptureVisiblePage(
-               extension.get(), url, tab_id, NULL) &&
-           HasTabsPermission(extension, tab_id);
+    bool script = PermissionsData::CanExecuteScriptOnPage(
+               extension.get(), url, url, tab_id, NULL, -1, NULL);
+    bool capture = HasTabsPermission(extension, tab_id) &&
+        PermissionsData::CanCaptureVisiblePage(extension.get(), tab_id, NULL);
+    switch (feature) {
+      case PERMITTED_SCRIPT_ONLY:
+        return script && !capture;
+      case PERMITTED_CAPTURE_ONLY:
+        return capture && !script;
+      case PERMITTED_BOTH:
+        return script && capture;
+      case PERMITTED_NONE:
+        return !script && !capture;
+    }
+    NOTREACHED();
+    return false;
   }
 
   bool IsBlocked(const scoped_refptr<const Extension>& extension,
                  const GURL& url) {
     return IsBlocked(extension, url, tab_id());
   }
 
   bool IsBlocked(const scoped_refptr<const Extension>& extension,
                  const GURL& url,
                  int tab_id) {
-    // Note: can't check HasTabsPermission because it isn't URL specific.
-    return !PermissionsData::CanExecuteScriptOnPage(
-               extension.get(), url, url, tab_id, NULL, -1, NULL) &&
-           !PermissionsData::CanCaptureVisiblePage(
-               extension.get(), url, tab_id, NULL);
+    return IsAllowed(extension, url, PERMITTED_NONE, tab_id);
   }
 
   bool HasTabsPermission(const scoped_refptr<const Extension>& extension) {
     return HasTabsPermission(extension, tab_id());
   }
 
   bool HasTabsPermission(const scoped_refptr<const Extension>& extension,
                          int tab_id) {
     return PermissionsData::HasAPIPermissionForTab(
         extension.get(), tab_id, APIPermission::kTab);
@@ skipping 41 matching lines @@
       extension_without_active_tab.get());
 
   // Granted to extension and extension_without_active_tab, but the latter
   // doesn't have the activeTab permission so not granted.
   EXPECT_TRUE(IsAllowed(extension, google));
   EXPECT_TRUE(IsBlocked(another_extension, google));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, google));
 
   // Other subdomains shouldn't be given access.
   GURL mail_google("http://mail.google.com");
-  EXPECT_TRUE(IsBlocked(extension, mail_google));
+  EXPECT_TRUE(IsAllowed(extension, mail_google, PERMITTED_CAPTURE_ONLY));
   EXPECT_TRUE(IsBlocked(another_extension, mail_google));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, mail_google));
 
   // Reloading the page should clear the active permissions.
   Reload();
 
   EXPECT_TRUE(IsBlocked(extension, google));
   EXPECT_TRUE(IsBlocked(another_extension, google));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, google));
 
@@ skipping 39 matching lines @@
   EXPECT_FALSE(HasTabsPermission(another_extension));
   EXPECT_FALSE(HasTabsPermission(extension_without_active_tab));
 
   // Should be able to grant to multiple extensions at the same time (if they
   // have the activeTab permission, of course).
   active_tab_permission_granter()->GrantIfRequested(extension.get());
   active_tab_permission_granter()->GrantIfRequested(another_extension.get());
   active_tab_permission_granter()->GrantIfRequested(
       extension_without_active_tab.get());
 
-  EXPECT_TRUE(IsBlocked(extension, google));
-  EXPECT_TRUE(IsBlocked(another_extension, google));
+  EXPECT_TRUE(IsAllowed(extension, google, PERMITTED_CAPTURE_ONLY));
+  EXPECT_TRUE(IsAllowed(another_extension, google, PERMITTED_CAPTURE_ONLY));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, google));
 
   EXPECT_TRUE(IsAllowed(extension, chromium));
   EXPECT_TRUE(IsAllowed(another_extension, chromium));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, chromium));
 
   // Should be able to go back to URLs that were previously cleared.
   NavigateAndCommit(google);
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
   active_tab_permission_granter()->GrantIfRequested(another_extension.get());
   active_tab_permission_granter()->GrantIfRequested(
       extension_without_active_tab.get());
 
   EXPECT_TRUE(IsAllowed(extension, google));
   EXPECT_TRUE(IsAllowed(another_extension, google));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, google));
 
-  EXPECT_TRUE(IsBlocked(extension, chromium));
-  EXPECT_TRUE(IsBlocked(another_extension, chromium));
+  EXPECT_TRUE(IsAllowed(extension, chromium, PERMITTED_CAPTURE_ONLY));
+  EXPECT_TRUE(IsAllowed(another_extension, chromium, PERMITTED_CAPTURE_ONLY));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, chromium));
 };
 
 TEST_F(ActiveTabTest, Uninstalling) {
   // Some semi-arbitrary setup.
   GURL google("http://www.google.com");
   NavigateAndCommit(google);
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
@@ skipping 19 matching lines @@
   EXPECT_TRUE(IsGrantedForTab(extension.get(), web_contents()));
   EXPECT_TRUE(IsAllowed(extension, google));
 }
 
 TEST_F(ActiveTabTest, OnlyActiveTab) {
   GURL google("http://www.google.com");
   NavigateAndCommit(google);
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
-  EXPECT_TRUE(IsAllowed(extension, google, tab_id()));
+  EXPECT_TRUE(IsAllowed(extension, google, PERMITTED_BOTH, tab_id()));
   EXPECT_TRUE(IsBlocked(extension, google, tab_id() + 1));
   EXPECT_FALSE(HasTabsPermission(extension, tab_id() + 1));
 }
 
 TEST_F(ActiveTabTest, NavigateInPage) {
   GURL google("http://www.google.com");
   NavigateAndCommit(google);
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
   // Perform an in-page navigation. The extension should not lose the temporary
   // permission.
   GURL google_h1("http://www.google.com#h1");
   NavigateAndCommit(google_h1);
 
-  EXPECT_TRUE(IsAllowed(extension, google, tab_id()));
-  EXPECT_TRUE(IsAllowed(extension, google_h1, tab_id()));
+  EXPECT_TRUE(IsAllowed(extension, google));
+  EXPECT_TRUE(IsAllowed(extension, google_h1));
 
   GURL chromium("http://www.chromium.org");
   NavigateAndCommit(chromium);
 
-  EXPECT_FALSE(IsAllowed(extension, google, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, google_h1, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, chromium, tab_id()));
+  EXPECT_FALSE(IsAllowed(extension, google));
+  EXPECT_FALSE(IsAllowed(extension, google_h1));
+  EXPECT_FALSE(IsAllowed(extension, chromium));
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
-  EXPECT_FALSE(IsAllowed(extension, google, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, google_h1, tab_id()));
-  EXPECT_TRUE(IsAllowed(extension, chromium, tab_id()));
+  EXPECT_FALSE(IsAllowed(extension, google));
+  EXPECT_FALSE(IsAllowed(extension, google_h1));
+  EXPECT_TRUE(IsAllowed(extension, chromium));
 
   GURL chromium_h1("http://www.chromium.org#h1");
   NavigateAndCommit(chromium_h1);
 
-  EXPECT_FALSE(IsAllowed(extension, google, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, google_h1, tab_id()));
-  EXPECT_TRUE(IsAllowed(extension, chromium, tab_id()));
-  EXPECT_TRUE(IsAllowed(extension, chromium_h1, tab_id()));
+  EXPECT_FALSE(IsAllowed(extension, google));
+  EXPECT_FALSE(IsAllowed(extension, google_h1));
+  EXPECT_TRUE(IsAllowed(extension, chromium));
+  EXPECT_TRUE(IsAllowed(extension, chromium_h1));
 
   Reload();
 
-  EXPECT_FALSE(IsAllowed(extension, google, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, google_h1, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, chromium, tab_id()));
-  EXPECT_FALSE(IsAllowed(extension, chromium_h1, tab_id()));
+  EXPECT_FALSE(IsAllowed(extension, google));
+  EXPECT_FALSE(IsAllowed(extension, google_h1));
+  EXPECT_FALSE(IsAllowed(extension, chromium));
+  EXPECT_FALSE(IsAllowed(extension, chromium_h1));
 }
 
 TEST_F(ActiveTabTest, ChromeUrlGrants) {
   GURL internal("chrome://version");
   NavigateAndCommit(internal);
   active_tab_permission_granter()->GrantIfRequested(
       extension_with_tab_capture.get());
   // Do not grant tabs/hosts permissions for tab.
-  EXPECT_TRUE(IsBlocked(extension_with_tab_capture, internal, tab_id()));
+  EXPECT_TRUE(IsAllowed(extension_with_tab_capture, internal,
+                        PERMITTED_CAPTURE_ONLY));
   EXPECT_TRUE(PermissionsData::HasAPIPermissionForTab(
       extension_with_tab_capture.get(),
       tab_id(),
       APIPermission::kTabCaptureForTab));
 
   EXPECT_TRUE(IsBlocked(extension_with_tab_capture, internal, tab_id() + 1));
   EXPECT_FALSE(PermissionsData::HasAPIPermissionForTab(
       extension_with_tab_capture.get(),
       tab_id() + 1,
       APIPermission::kTabCaptureForTab));
 }
 
 }  // namespace
 }  // namespace extensions