Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4866)

Unified Diff: chrome/browser/ui/search/instant_page.h

Issue 14043009: Fall back to local page if online NTP fails to load. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix failing tests Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_page.h
diff --git a/chrome/browser/ui/search/instant_page.h b/chrome/browser/ui/search/instant_page.h
index 6bae2655ca53bbfffd6a6a4075cb571f7e0d283c..b8239cd483ed5b008dfe9d37ae095aaaf83e86e9 100644
--- a/chrome/browser/ui/search/instant_page.h
+++ b/chrome/browser/ui/search/instant_page.h
@@ -19,6 +19,8 @@ class GURL;
namespace content {
class WebContents;
+struct FrameNavigateParams;
+struct LoadCommittedDetails;
sreeram 2013/05/03 23:17:31 The ordering should be by the identifier name (ign
David Black 2013/05/04 00:49:23 Done.
}
namespace gfx {
@@ -91,6 +93,9 @@ class InstantPage : public content::WebContentsObserver {
// Called when the SearchBox wants to undo all Most Visited deletions.
virtual void UndoAllMostVisitedDeletions() = 0;
+ // Called when the preloaded NTP is ready for display.
samarth 2013/05/03 04:39:17 Fix comment please
David Black 2013/05/03 06:14:44 Done.
sreeram 2013/05/03 23:17:31 Not done?
David Black 2013/05/04 00:49:23 Done.
+ virtual void InstantPageLoadFailed(content::WebContents* contents) = 0;
+
protected:
virtual ~Delegate();
};
@@ -215,6 +220,16 @@ class InstantPage : public content::WebContentsObserver {
const GURL& url,
content::PageTransition transition_type,
content::RenderViewHost* render_view_host) OVERRIDE;
+ virtual void DidNavigateMainFrame(
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) OVERRIDE;
+ virtual void DidFailProvisionalLoad(
+ int64 frame_id,
+ bool is_main_frame,
+ const GURL& validated_url,
+ int error_code,
+ const string16& error_description,
+ content::RenderViewHost* render_view_host) OVERRIDE;
void OnSetSuggestions(int page_id,
const std::vector<InstantSuggestion>& suggestions);

Powered by Google App Engine
This is Rietveld 408576698