Fall back to local page if online NTP fails to load.

chrome/browser/ui/search/instant_tab.cc

Index: chrome/browser/ui/search/instant_tab.cc
diff --git a/chrome/browser/ui/search/instant_tab.cc b/chrome/browser/ui/search/instant_tab.cc
index 47e4f3d06c4a36073bafbead2b80bf0b91899852..acdaf7fc326f2eed93c8fdf14be3dbbe635f6bf2 100644
--- a/chrome/browser/ui/search/instant_tab.cc
+++ b/chrome/browser/ui/search/instant_tab.cc
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/instant_tab.h"
+#include "content/public/browser/web_contents.h"
 
 InstantTab::InstantTab(InstantPage::Delegate* delegate)
     : InstantPage(delegate) {
@@ -13,7 +14,8 @@ InstantTab::~InstantTab() {
 
 void InstantTab::Init(content::WebContents* contents) {
   SetContents(contents);
-  DetermineIfPageSupportsInstant();
+  if (!contents->IsLoading())

[samarth, 2013/05/01 06:26:47]

Can you explain why you need this change?

[David Black, 2013/05/02 00:49:45]

If you hook up an instant tab to a page that is still loading (say because it
was just redirected to the offline page) this will fire too early and cause
Chrome to mistakenly think the page doesn't support Instant. 
InstantPage::DidFinishLoad will fire off DetermineIfPageSupportsInstant at the
correct time in the case instant_tab is bound while the page is still loading.

[samarth, 2013/05/02 03:12:56]

Is this change still necessary now that you're no longer resetting instant tab
and just re-initializing the data?

[David Black, 2013/05/02 05:02:49]

Perhaps not, but it seems like a sane check to have in here in any case.  I'd
prefer to leave it.

+    DetermineIfPageSupportsInstant();
 }
 
 bool InstantTab::ShouldProcessSetSuggestions() {