Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/search/instant_controller.h

Issue 14043009: Fall back to local page if online NTP fails to load. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove logic to always try to load a server-provided NTP on frontmost tab. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_controller.h
diff --git a/chrome/browser/ui/search/instant_controller.h b/chrome/browser/ui/search/instant_controller.h
index 6822b28616b728a231bfea09a20627f74cec72c9..086419895fb3cf4ecce7bfffbab601b97f294725 100644
--- a/chrome/browser/ui/search/instant_controller.h
+++ b/chrome/browser/ui/search/instant_controller.h
@@ -266,6 +266,7 @@ class InstantController : public InstantPage::Delegate,
const GURL& url,
content::PageTransition transition,
WindowOpenDisposition disposition) OVERRIDE;
+ virtual void InstantPageLoadFailed(content::WebContents* contents) OVERRIDE;
// Invoked by the InstantLoader when the Instant page wants to delete a
// Most Visited item.
@@ -281,6 +282,10 @@ class InstantController : public InstantPage::Delegate,
// Most Visited deletions.
virtual void UndoAllMostVisitedDeletions() OVERRIDE;
+ // Helper function to navigate the given contents to the local fallback
+ // Instant URL and trim the history correctly.
+ void RedirectToLocalNTP(content::WebContents* contents);
+
// Helper for OmniboxFocusChanged. Commit or discard the overlay.
void OmniboxLostFocus(gfx::NativeView view_gaining_focus);

Powered by Google App Engine
This is Rietveld 408576698