Fall back to local page if online NTP fails to load.

chrome/browser/search/search.cc

Index: chrome/browser/search/search.cc
diff --git a/chrome/browser/search/search.cc b/chrome/browser/search/search.cc
index ba0820034c10d4e72a5531096e2dc58eae104b0b..477ea95fea01c6091cd1fc4e64188eea8b493299 100644
--- a/chrome/browser/search/search.cc
+++ b/chrome/browser/search/search.cc
@@ -160,8 +160,7 @@ bool IsInstantURL(const GURL& url, Profile* profile) {
   GURL effective_url = url;
 
   if (IsCommandLineInstantURL(url))
-    effective_url = CoerceCommandLineURLToTemplateURL(url, instant_url_ref,
-                                                      kDisableStartMargin);
+    return true;

[samarth, 2013/04/30 17:10:33]

I assume this was for debugging. (Shouldn't be necessary btw. Just
--instant-url='http://does/not/exist/?espv=2' should work.)

[David Black, 2013/04/30 23:09:08]

No, this is necessary, as that URL otherwise doesn't work. 
CoerceCommandLineURLToTemplateURL doesn't change the path, and below we check
MatchesOriginAndPath vs the built-in template URL.  So, if it's not a /search or
/webhp page then no go.  It took me a while to debug why on earth using
--instant-url="https://www.google.com/notarealpah?espv=2" was generating a bunch
of really mysterious behavior.

[samarth, 2013/05/01 06:26:47]

In that case, you should change Coerce... to also change the path.  I think you
still want search term extraction, etc. to still work even if you're using a
custom path.

[David Black, 2013/05/02 00:49:45]

Search term extraction still does work.  It's only here in this function where
we coerce a URL and then verify its path matches the vanilla template URL.  It
seems quite clear to me that a function called IsInstantURL should always simply
return true if IsCommandLineInstantURL returns true - having any coercing going
on at all in this function makes no sense to me.

 
   if (!effective_url.is_valid())
     return false;