[turbofan] Remove the --turbo-allocate flag.

[turbofan] Remove the --turbo-allocate flag.

The CL also fixes various small bugs in context allocation.

Committed: https://crrev.com/87aab49a4201b60fe0321ea4fef24bad6218e950
Cr-Commit-Position: refs/heads/master@{#31311}

[Jarin, 2015-10-15 13:42:50]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2015-10-15 13:47:48]

Could you take a look, please?

[Michael Starzinger, 2015-10-15 13:54:29]

LGTM with nits.

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (left):

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:1281:
a.Store(AccessBuilder::ForContextSlot(i), jsgraph()->TheHoleConstant());
Ooops, that was my bad, sorry!

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:1311: // Use inline allocation for with
contexts for regular objects.
nit: Please bring back my comment and my empty newline.

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:1343: // Use inline allocation for block
contexts up to a size limit.
nit: Please bring back my comment.

[Jarin, 2015-10-15 14:22:24]

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
File src/compiler/js-typed-lowering.cc (left):

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:1281:
a.Store(AccessBuilder::ForContextSlot(i), jsgraph()->TheHoleConstant());
On 2015/10/15 13:54:29, Michael Starzinger wrote:
> Ooops, that was my bad, sorry!

Acknowledged.

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:1311: // Use inline allocation for with
contexts for regular objects.
On 2015/10/15 13:54:29, Michael Starzinger wrote:
> nit: Please bring back my comment and my empty newline.

Oops, that fell victim to manual rebase. Fixed now.

https://codereview.chromium.org/1404293002/diff/20001/src/compiler/js-typed-l...
src/compiler/js-typed-lowering.cc:1343: // Use inline allocation for block
contexts up to a size limit.
On 2015/10/15 13:54:29, Michael Starzinger wrote:
> nit: Please bring back my comment.

Done.

[Jarin, 2015-10-15 14:54:26]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2015-10-15 14:54:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1404293002/#ps40001
(title: "Fix comments")

[commit-bot: I haz the power, 2015-10-15 14:54:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404293002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404293002/40001

[commit-bot: I haz the power, 2015-10-15 16:11:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-15 16:11:28]

Patchset 3 (id:??) landed as
https://crrev.com/87aab49a4201b60fe0321ea4fef24bad6218e950
Cr-Commit-Position: refs/heads/master@{#31311}