src/conversions-inl.h - Issue 1404283002: Unify ToArrayLength conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/conversions-inl.h

Issue 1404283002: Unify ToArrayLength conversions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/conversions-inl.h

diff --git a/src/conversions-inl.h b/src/conversions-inl.h

index f1ccb1537714d8f4dab001c5a88649a468d238f2..c05c0644da5eb675c75b6b6617df29fba418cfe9 100644

--- a/src/conversions-inl.h

+++ b/src/conversions-inl.h

@@ -70,7 +70,7 @@ inline unsigned int FastD2UI(double x) {

inline float DoubleToFloat32(double x) {

- // TODO(yanggou): This static_cast is implementation-defined behaviour in C++,

+ // TODO(yangguo): This static_cast is implementation-defined behaviour in C++,

// so we may need to do the conversion manually instead to match the spec.

volatile float f = static_cast<float>(x);

return f;

« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »