Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: src/objects.h

Issue 1404283002: Unify ToArrayLength conversions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/conversions-inl.h ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 10058 matching lines...) Expand 10 before | Expand all | Expand 10 after
10069 uint32_t length); 10069 uint32_t length);
10070 10070
10071 // Set the content of the array to the content of storage. 10071 // Set the content of the array to the content of storage.
10072 static inline void SetContent(Handle<JSArray> array, 10072 static inline void SetContent(Handle<JSArray> array,
10073 Handle<FixedArrayBase> storage); 10073 Handle<FixedArrayBase> storage);
10074 10074
10075 static bool DefineOwnProperty(Isolate* isolate, Handle<JSArray> o, 10075 static bool DefineOwnProperty(Isolate* isolate, Handle<JSArray> o,
10076 Handle<Object> name, PropertyDescriptor* desc, 10076 Handle<Object> name, PropertyDescriptor* desc,
10077 ShouldThrow should_throw); 10077 ShouldThrow should_throw);
10078 10078
10079 static bool AnythingToArrayLength(Isolate* isolate,
10080 Handle<Object> length_object,
10081 uint32_t* output);
10079 static bool ArraySetLength(Isolate* isolate, Handle<JSArray> a, 10082 static bool ArraySetLength(Isolate* isolate, Handle<JSArray> a,
10080 PropertyDescriptor* desc, 10083 PropertyDescriptor* desc,
10081 ShouldThrow should_throw); 10084 ShouldThrow should_throw);
10082 10085
10083 DECLARE_CAST(JSArray) 10086 DECLARE_CAST(JSArray)
10084 10087
10085 // Dispatched behavior. 10088 // Dispatched behavior.
10086 DECLARE_PRINTER(JSArray) 10089 DECLARE_PRINTER(JSArray)
10087 DECLARE_VERIFIER(JSArray) 10090 DECLARE_VERIFIER(JSArray)
10088 10091
(...skipping 640 matching lines...) Expand 10 before | Expand all | Expand 10 after
10729 Handle<FixedArray> keys_; 10732 Handle<FixedArray> keys_;
10730 Handle<OrderedHashSet> set_; 10733 Handle<OrderedHashSet> set_;
10731 int length_; 10734 int length_;
10732 DISALLOW_COPY_AND_ASSIGN(KeyAccumulator); 10735 DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
10733 }; 10736 };
10734 10737
10735 } // NOLINT, false-positive due to second-order macros. 10738 } // NOLINT, false-positive due to second-order macros.
10736 } // NOLINT, false-positive due to second-order macros. 10739 } // NOLINT, false-positive due to second-order macros.
10737 10740
10738 #endif // V8_OBJECTS_H_ 10741 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/conversions-inl.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698