Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 14042008: Adds EXTERNAL_DOUBLE_ARRAY to a list of instance types (Closed)

Created:
7 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Adds EXTERNAL_DOUBLE_ARRAY to a list of instance types BUG=v8:2646 Patch by Andrei Kashcha <anvaka@gmail.com>; Committed: https://code.google.com/p/v8/source/detail?r=14398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-2646.js View 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
Please take a look
7 years, 8 months ago (2013-04-23 09:10:03 UTC) #1
Yang
On 2013/04/23 09:10:03, Dmitry Lomov (chromium) wrote: > Please take a look LGTM.
7 years, 8 months ago (2013-04-23 09:16:14 UTC) #2
Dmitry Lomov (no reviews)
7 years, 8 months ago (2013-04-23 17:02:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698