Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: ui/touch_selection/touch_selection_controller.cc

Issue 1404163004: Swap touch selection handles when they are interchanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: linux build error Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/touch_selection_controller.cc
diff --git a/ui/touch_selection/touch_selection_controller.cc b/ui/touch_selection/touch_selection_controller.cc
index 90f7c6241580f66532ff678d360f070a8fa82bc3..3baf946ea9dbcea156e01cec355b7d81a48d0b1b 100644
--- a/ui/touch_selection/touch_selection_controller.cc
+++ b/ui/touch_selection/touch_selection_controller.cc
@@ -89,6 +89,16 @@ void TouchSelectionController::OnSelectionBoundsChanged(
client_->OnSelectionEvent(SELECTION_DISSOLVED);
}
+ // Swap the Handles when the start and end selection points cross each other.
+ if (active_status_ == SELECTION_ACTIVE) {
+ if ((start_selection_handle_->IsActive() &&
+ end_.edge_bottom() == start.edge_bottom()) ||
+ (end_selection_handle_->IsActive() &&
+ end.edge_bottom() == start_.edge_bottom())) {
+ start_selection_handle_.swap(end_selection_handle_);
+ }
+ }
+
start_ = start;
end_ = end;
start_orientation_ = ToTouchHandleOrientation(start_.type());

Powered by Google App Engine
This is Rietveld 408576698