Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404163002: VM: Precompile method extractors for implicit and explicit closurization. (Closed)

Created:
5 years, 2 months ago by Florian Schneider
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Precompile method extractors for implicit and explicit closurization. Also, avoid creating duplicate method extractors with explicit closurization: Before the compiler would create one extractor per site when using the explicit #-closurization operator. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7fe1e05826a3e45baaede03e68304832309295fe

Patch Set 1 #

Patch Set 2 : added comment #

Patch Set 3 : fixed missing precompiled functions with hash-closurization #

Total comments: 4

Patch Set 4 : fix hash-closurization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -54 lines) Patch
M runtime/vm/object.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 2 3 4 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/resolver.cc View 1 2 3 4 chunks +10 lines, -53 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Florian Schneider
5 years, 2 months ago (2015-10-14 15:04:14 UTC) #2
Florian Schneider
Hold off with reviewing for now - my last patchset broke something.
5 years, 2 months ago (2015-10-14 17:01:18 UTC) #3
rmacnak
https://codereview.chromium.org/1404163002/diff/40001/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1404163002/diff/40001/runtime/vm/precompiler.cc#newcode584 runtime/vm/precompiler.cc:584: AddImplicitClosure(function, selector3); This one wants an invoke-field dispatcher, not ...
5 years, 2 months ago (2015-10-14 17:07:34 UTC) #4
Florian Schneider
Ptal. IC misses are reduced by 80% on CompileOnceHelloHtml from ~80K to 16K misses. https://codereview.chromium.org/1404163002/diff/40001/runtime/vm/precompiler.cc ...
5 years, 2 months ago (2015-10-14 17:55:54 UTC) #5
rmacnak
lgtm
5 years, 2 months ago (2015-10-14 20:07:05 UTC) #6
Florian Schneider
Committed patchset #4 (id:60001) manually as 7fe1e05826a3e45baaede03e68304832309295fe (presubmit successful).
5 years, 2 months ago (2015-10-15 10:27:28 UTC) #7
Florian Schneider
5 years, 2 months ago (2015-10-15 14:23:45 UTC) #8
Message was sent while issue was closed. 
This gives +10% on dart2js CompileOnceHelloHtml.

Powered by Google App Engine
This is Rietveld 408576698