Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404153002: Fix TextBlobTest valgrind error (Closed)

Created:
5 years, 2 months ago by f(malita)
Modified:
5 years, 2 months ago
Reviewers:
bungeman-skia, herb_g
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix TextBlobTest valgrind error When converting text to glyph IDs, the paint needs to reflect the actual text encoding. R=bungeman@google.com,herb@google.com Committed: https://skia.googlesource.com/skia/+/0b01da7bca9dacdd58affe5d5433860cb3d59194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M tests/TextBlobTest.cpp View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
f(malita)
5 years, 2 months ago (2015-10-14 14:53:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404153002/1
5 years, 2 months ago (2015-10-14 14:53:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 15:01:22 UTC) #7
herb_g
lgtm
5 years, 2 months ago (2015-10-14 15:05:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404153002/1
5 years, 2 months ago (2015-10-14 15:10:53 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 15:11:45 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0b01da7bca9dacdd58affe5d5433860cb3d59194

Powered by Google App Engine
This is Rietveld 408576698