cc/trees/layer_tree_host_impl.cc - Issue 140413007: Made fling gestures always bubble between inner and outer viewports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 140413007: Made fling gestures always bubble between inner and outer viewports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Made test non-symmetric Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_impl.cc

diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc

index 326f1fe2afe25747876d5adae91fa658b5661700..16571a2e4f1ba1b222aec0de628edd1fd258390b 100644

--- a/cc/trees/layer_tree_host_impl.cc

+++ b/cc/trees/layer_tree_host_impl.cc

@@ -2240,7 +2240,9 @@ bool LayerTreeHostImpl::ScrollBy(gfx::Point viewport_point,

did_scroll_x |= did_move_layer_x;

did_scroll_y |= did_move_layer_y;

if (!did_move_layer_x && !did_move_layer_y) {

- if (should_bubble_scrolls_ || !did_lock_scrolling_layer_)

+ // Scrolls should always bubble between the outer and inner viewports

+ if (should_bubble_scrolls_ || !did_lock_scrolling_layer_ ||

+ layer_impl == OuterViewportScrollLayer())

continue;

else

break;

« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »