Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 1404123002: [turbofan] Move native context specialization before inlining. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move native context specialization before inlining. Perform native context specialization immediately after graph construction (also after inlinee graph construction). This way we can do unified inlining before we go to typing and typed lowering. And we will get better typing due to constants and (checked) type feedback. R=mstarzinger@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/d702f70795a0be3aa219153af6769474ee823290 Cr-Commit-Position: refs/heads/master@{#31255}

Patch Set 1 #

Total comments: 2

Patch Set 2 : No more JSGraphReducer in JSInliner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -19 lines) Patch
M src/compiler/js-inlining.cc View 1 3 chunks +37 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +35 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
Hey Michi, As discussed offline. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-14 11:23:55 UTC) #2
Michael Starzinger
LGTM with one comment to address. https://codereview.chromium.org/1404123002/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1404123002/diff/1/src/compiler/js-inlining.cc#newcode267 src/compiler/js-inlining.cc:267: : GraphReducer(zone, jsgraph->graph(), ...
5 years, 2 months ago (2015-10-14 11:28:57 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1404123002/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1404123002/diff/1/src/compiler/js-inlining.cc#newcode267 src/compiler/js-inlining.cc:267: : GraphReducer(zone, jsgraph->graph(), jsgraph->Dead()) {} On 2015/10/14 11:28:57, Michael ...
5 years, 2 months ago (2015-10-14 11:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404123002/20001
5 years, 2 months ago (2015-10-14 11:29:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 12:20:45 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 12:21:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d702f70795a0be3aa219153af6769474ee823290
Cr-Commit-Position: refs/heads/master@{#31255}

Powered by Google App Engine
This is Rietveld 408576698