Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404063003: Fix regression in 49abac87faa60. (Closed)

Created:
5 years, 2 months ago by M-A Ruel
Modified:
5 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix regression in 49abac87faa60. Paths must be unicode instances. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/f3b179e1a47abefbe93b76350bb31c27ed620425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M client/swarming.py View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
M-A Ruel
5 years, 2 months ago (2015-10-14 01:33:49 UTC) #1
Vadim Sh.
lgtm I suspect it's not the first CL of that kind...
5 years, 2 months ago (2015-10-14 01:37:13 UTC) #2
M-A Ruel
On 2015/10/14 01:37:13, Vadim Sh. wrote: > lgtm > > I suspect it's not the ...
5 years, 2 months ago (2015-10-14 01:39:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404063003/1
5 years, 2 months ago (2015-10-14 01:39:23 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 01:40:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/f3b179e1a47abefbe93b76350bb31c27ed620425

Powered by Google App Engine
This is Rietveld 408576698