relnote: Disables strike register lookups when talking QUIC_VERSION_27

relnote: Disables strike register lookups when talking QUIC_VERSION_27
or higher (not yet used by Chrome).

Merge internal change: 103965712

R=rch@chromium.org

[Ryan Hamilton, 2015-10-13 22:39:47]

lgtm

[ramant (doing other things), 2015-10-14 22:40:06]

Patchset #2 (id:20001) has been deleted

[ramant (doing other things), 2015-10-14 22:44:52]

Patchset #2 (id:40001) has been deleted

[ramant (doing other things), 2015-10-14 22:47:11]

Patchset #2 (id:60001) has been deleted

[ramant (doing other things), 2015-10-14 22:51:36]

As we had debugged offline, disabled FLAGS_quic_require_handshake_confirmation
(because crypto_server_tests are failing). This flag is disabled in the internal
source also.

Moved certificate checks for version <= 26 (added a TODO).

PTAL.

https://codereview.chromium.org/1404053002/diff/80001/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/1404053002/diff/80001/net/quic/quic_flags.cc#...
net/quic/quic_flags.cc:55: bool FLAGS_quic_require_handshake_confirmation =
false;
Disabled FLAGS_quic_require_handshake_confirmation flag.

[ramant (doing other things), 2015-10-14 23:50:31]

On 2015/10/14 22:51:36, ramant wrote:
> As we had debugged offline, disabled FLAGS_quic_require_handshake_confirmation
> (because crypto_server_tests are failing). This flag is disabled in the
internal
> source also.
> 
> Moved certificate checks for version <= 26 (added a TODO).
> 
> PTAL.
> 
> https://codereview.chromium.org/1404053002/diff/80001/net/quic/quic_flags.cc
> File net/quic/quic_flags.cc (right):
> 
>
https://codereview.chromium.org/1404053002/diff/80001/net/quic/quic_flags.cc#...
> net/quic/quic_flags.cc:55: bool FLAGS_quic_require_handshake_confirmation =
> false;
> Disabled FLAGS_quic_require_handshake_confirmation flag.

Hi Ryan,
  For ProofSourceForTesting, used quic_test.example.com.crt and that has reduced
the
certificate size (compressed size) and was able to verify tests.

  PATL.

Hi Robbie,
  crypto_server_tests are not really testing versions less than VERSION_28.
Would like
to add version as a parameter (because some of the tests are doing different
things
based on QUIC_VERSIOB).

  Will add another CL and upload it into the internal source tree.

thanks
raman

[Ryan Hamilton, 2015-10-15 00:10:35]

lgtm

Thanks for tracking this down!

[ramant (doing other things), 2015-10-15 00:33:55]

On 2015/10/15 00:10:35, Ryan Hamilton wrote:
> lgtm
> 
> Thanks for tracking this down!

Thanks very much Ryan for being patient (and listening to my nonsense)
and for your help to debug the issue.

[Ryan Hamilton, 2015-10-15 17:56:12]

On 2015/10/15 00:33:55, ramant wrote:
> On 2015/10/15 00:10:35, Ryan Hamilton wrote:
> > lgtm
> > 
> > Thanks for tracking this down!
> 
> Thanks very much Ryan for being patient (and listening to my nonsense)
> and for your help to debug the issue.

My pleasure. No nonsense at all. This was a tricky one!