Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1404043002: Connect to DeviceManager lazily in WebUSBClientImpl. (Closed)

Created:
5 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Connect to DeviceManager lazily in WebUSBClientImpl. Every WebLocalFrameImpl results in the creation of a WebUSBClientImpl so this patch delays the connection to the embedder's DeviceManager implementation until it is actually needed. This means it will end up being connected when the navigator.usb object is first accessed by Javascript. This avoids exposing everyone who has enabled the experimental web platform features flag to instabilities in this new feature and will generally reduce resource utilization for unused features when this is shipped. BUG=538339 Committed: https://crrev.com/fd6c723ff1b86bdc3c8036017eae3bbd80127840 Cr-Commit-Position: refs/heads/master@{#353909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M content/renderer/usb/web_usb_client_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/usb/web_usb_client_impl.cc View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 2 months ago (2015-10-13 22:17:52 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 2 months ago (2015-10-13 22:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404043002/1
5 years, 2 months ago (2015-10-13 22:57:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:43:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:45:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd6c723ff1b86bdc3c8036017eae3bbd80127840
Cr-Commit-Position: refs/heads/master@{#353909}

Powered by Google App Engine
This is Rietveld 408576698