Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1404033002: Switch googletest and googlemock to pull from the GitHub git repository (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Switch googletest and googlemock to pull from the GitHub git repository R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6e89d45d7d7d66f7bd5fa326c013d096d28eb179

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : 71a26ac68b28 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -388 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M client/client_test.gyp View 1 1 chunk +2 lines, -2 lines 2 comments Download
M test/test_test.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/gmock/README.crashpad View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/gmock/gmock.gyp View 1 1 chunk +0 lines, -220 lines 0 comments Download
M third_party/gtest/README.crashpad View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + third_party/gtest/gmock.gyp View 1 8 chunks +66 lines, -67 lines 0 comments Download
M third_party/gtest/gtest.gyp View 1 14 chunks +80 lines, -71 lines 0 comments Download
M util/util_test.gyp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Mentovai
gtest’s and gmock’s own tests don’t build on Windows, but I don’t think they did ...
5 years, 1 month ago (2015-11-11 00:22:15 UTC) #3
scottmg
lgtm https://codereview.chromium.org/1404033002/diff/60001/client/client_test.gyp File client/client_test.gyp (right): https://codereview.chromium.org/1404033002/diff/60001/client/client_test.gyp#newcode27 client/client_test.gyp:27: '../third_party/gtest/gmock.gyp:gmock_main', gtest_main still exists, but you switched to ...
5 years, 1 month ago (2015-11-11 04:04:11 UTC) #4
Mark Mentovai
https://codereview.chromium.org/1404033002/diff/60001/client/client_test.gyp File client/client_test.gyp (right): https://codereview.chromium.org/1404033002/diff/60001/client/client_test.gyp#newcode27 client/client_test.gyp:27: '../third_party/gtest/gmock.gyp:gmock_main', scottmg wrote: > gtest_main still exists, but you ...
5 years, 1 month ago (2015-11-11 14:58:35 UTC) #5
Mark Mentovai
5 years, 1 month ago (2015-11-11 16:13:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6e89d45d7d7d66f7bd5fa326c013d096d28eb179 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698