Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 140403002: Mojo: Add the ability to hook up a channel to the embedder API. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add the ability to hook up a channel to the embedder API. That is, starting with an OS "channel" (e.g., socket), you can tell the system to set up to send messages over it. It'll provide an initial "bootstrap" message pipe, from which you'll eventually be able to bring up more message pipes multiplexed on that channel (once you can pass handles in messages over the channel). Also: - Make a base class for tests that need an IO thread. - Add a way for test embedders to shut down the global instance. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245251

Patch Set 1 #

Patch Set 2 : remove export #

Patch Set 3 : win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -77 lines) Patch
M mojo/common/test/multiprocess_test_base_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/mojo.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/public/system/core_private.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/system/core_private.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/system/core_impl.h View 3 chunks +4 lines, -15 lines 0 comments Download
M mojo/system/core_impl.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M mojo/system/core_test_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/system/embedder.h View 1 chunk +38 lines, -0 lines 0 comments Download
M mojo/system/embedder.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A mojo/system/embedder_unittest.cc View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 5 chunks +5 lines, -23 lines 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 5 chunks +5 lines, -22 lines 0 comments Download
A mojo/system/test_embedder.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A mojo/system/test_embedder.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/system/test_utils.h View 2 chunks +29 lines, -1 line 0 comments Download
M mojo/system/test_utils.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
Notes: - I definitely want to make a separate directory for embedder stuff and move ...
6 years, 11 months ago (2014-01-16 01:17:24 UTC) #1
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-16 08:44:15 UTC) #2
viettrungluu
6 years, 11 months ago (2014-01-16 18:10:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r245251 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698