Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2031)

Unified Diff: dart/tools/bots/compiler.py

Issue 14040005: Little more host-checked mode on dart2js build bots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/bots/compiler.py
diff --git a/dart/tools/bots/compiler.py b/dart/tools/bots/compiler.py
index ff1eb3378beaeabe10a70db4599ed1385da44f04..ed93147e83b3f818a00da34ac80a5f59f1a7de39 100644
--- a/dart/tools/bots/compiler.py
+++ b/dart/tools/bots/compiler.py
@@ -210,7 +210,9 @@ def TestCompiler(runtime, mode, system, flags, is_buildbot, test_set):
# The dart2js compiler isn't self-hosted (yet) so we run its
# unit tests on the VM. We avoid doing this on the builders
# that run the browser tests to cut down on the cycle time.
- TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'], flags)
+ TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'],
+ # Run the unit tests in checked mode (the VM's checked mode).
+ ['--checked'])
ricow1 2013/04/12 10:39:55 don't we already do this on the dart2js checked bu
if system.startswith('win') and runtime.startswith('ie10'):
TestStep("dart2js", mode, system, 'dart2js', runtime, ['html'], flags)
@@ -220,7 +222,9 @@ def TestCompiler(runtime, mode, system, flags, is_buildbot, test_set):
# TODO(kasperl): Consider running peg and css tests too.
extras = ['dart2js_extra', 'dart2js_native', 'dart2js_foreign']
- TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras, flags)
+ TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras,
+ # Run this small test subset in checked mode.
+ flags + ['--host-checked'])
def _DeleteTempWebdriverProfiles(directory):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698