Issue 1403983004: [chromedriver] Enable geolocation by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1403983004: [chromedriver] Enable geolocation by default. (Closed)

Created:
5 years, 2 months ago by samuong

Modified:
5 years, 2 months ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[chromedriver] Enable geolocation by default. This is disabled by default in M46+. BUG= TBR=stgao@chromium.org Committed: https://crrev.com/b5f47482d2f8ad5172a93d7c8ce4b2f1796f02c6 Cr-Commit-Position: refs/heads/master@{#353896}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/test/chromedriver/chrome/preferences.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403983004/1

5 years, 2 months ago (2015-10-13 22:48:28 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/b5f47482d2f8ad5172a93d7c8ce4b2f1796f02c6 Cr-Commit-Position: refs/heads/master@{#353896}

5 years, 2 months ago (2015-10-13 23:19:19 UTC) #6

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages