AS strong-mode .analysis_options awareness.

pkg/analysis_server/lib/src/context_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library context.directory.manager;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:core' hide Resource;
@@ skipping 466 matching lines @@
         (OptionsProcessor p) => p.optionsProcessed(info.context, options));
 
     // Analysis options are processed 'in-line'.
     // TODO(pq): consider pushing exclude handling into a plugin.
     YamlMap analyzer = options['analyzer'];
     if (analyzer == null) {
       // No options for analyzer.
       return;
     }
 
+    // Set strong mode.
+    var strongMode = analyzer['strong-mode'];
+    if (strongMode != null && strongMode == true) {

[Brian Wilkerson, 2015/10/13 20:12:02]

The expression "strongMode != null" isn't necessary.

+      AnalysisContext context = info.context;
+      AnalysisOptionsImpl options =
+          new AnalysisOptionsImpl.from(context.analysisOptions);
+      options.strongMode = true;

[Jennifer Messerly, 2015/10/13 20:00:28]

we had an issue at some point where we also needed to set the SDK context:
https://github.com/dart-lang/dev_compiler/blob/6fe74a269f7877b6aae3d03bfd9be9...

Not sure if that's still the case or not... Maybe Leaf/Brian remember what the
issue was?

[pquitslund, 2015/10/13 20:10:58]

Oh!  Interesting.  Leaf/Brian?

[Brian Wilkerson, 2015/10/13 20:12:02]

I don't remember. But eventually, to support this with the semantics we talked
about yesterday, we'll probably need two SDK's: one with strong mode enabled and
one with strong mode disabled. We should be able to create them lazily.

[Leaf, 2015/10/13 20:20:38]

Will we be analyzing the SDK in strong mode with this CL, or only user code?  It
shouldn't make much difference now, but once we start adding generic method
annotations that might change.

[Jennifer Messerly, 2015/10/13 20:20:54]

yeah. I guess this isn't a big issue yet, until we try using generic methods in
the SDK. At that point, we'd also likely want to be able to point at an
experimental SDK sources to analyze.

I guess we can try it out and see how it's working now, and cross that other
bridge when we come to it.

+      context.analysisOptions = options;
+    }
+
     // Set ignore patterns.
     YamlList exclude = analyzer['exclude'];
     if (exclude != null) {
       setIgnorePatternsForContext(info, exclude);
     }
   }
 
   @override
   void refresh(List<Resource> roots) {
     // Destroy old contexts
@@ skipping 935 matching lines @@
           var path = resourceProvider.pathContext.fromUri(uri);
           packageMap[name] = <Folder>[resourceProvider.getFolder(path)];
         }
       });
       return <UriResolver>[new SdkExtUriResolver(packageMap)];
     } else {
       return const <UriResolver>[];
     }
   }
 }