Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1403973002: Remove unused gfx::Canvas API (Closed)

Created:
5 years, 2 months ago by tomhudson
Modified:
5 years, 2 months ago
Reviewers:
danakj, Tom Hudson
CC:
chromium-reviews, djsollen1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused gfx::Canvas API Canvas::BeginPlatformPaint() and EndPlatformPaint() have no callers. R=danakj@chromium.org CC=djsollen@chromium.org Committed: https://crrev.com/35f97018b601b2c17d7408397365c67c8c5099e7 Cr-Commit-Position: refs/heads/master@{#353889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M ui/gfx/canvas.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Hudson
Dana, PTAL - we're trying to clean up skia/ext/, and removing dead code calling into ...
5 years, 2 months ago (2015-10-13 19:11:43 UTC) #2
danakj
LGTM
5 years, 2 months ago (2015-10-13 21:00:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403973002/1
5 years, 2 months ago (2015-10-13 21:44:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 22:58:02 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:58:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35f97018b601b2c17d7408397365c67c8c5099e7
Cr-Commit-Position: refs/heads/master@{#353889}

Powered by Google App Engine
This is Rietveld 408576698