Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1403963003: Rename AccessibilityChildrenVector to AXObjectVector (Closed)

Created:
5 years, 2 months ago by aboxhall
Modified:
5 years, 2 months ago
Reviewers:
esprehn, dmazzoni
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, chromium-reviews, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, nektarios, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename AccessibilityChildrenVector to AXObjectVector Committed: https://crrev.com/feff5b3ca8a84606840ddb2b7f0d87127897c1c8 Cr-Commit-Position: refs/heads/master@{#353871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 8 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
aboxhall
Simple find/replace.
5 years, 2 months ago (2015-10-13 20:32:08 UTC) #2
dmazzoni
lgtm
5 years, 2 months ago (2015-10-13 20:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403963003/1
5 years, 2 months ago (2015-10-13 20:43:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/109061)
5 years, 2 months ago (2015-10-13 21:11:05 UTC) #7
aboxhall
+esprehn for Source/web
5 years, 2 months ago (2015-10-13 21:47:19 UTC) #9
esprehn
lgtm. nit: please remove empty BUG= lines
5 years, 2 months ago (2015-10-13 21:50:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403963003/1
5 years, 2 months ago (2015-10-13 21:55:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 22:13:39 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:14:53 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/feff5b3ca8a84606840ddb2b7f0d87127897c1c8
Cr-Commit-Position: refs/heads/master@{#353871}

Powered by Google App Engine
This is Rietveld 408576698