Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1403933003: [webnfc] : Dictionaries in IDL are not Web exposed, so remove RuntimeEnabled= . (Closed)

Created:
5 years, 2 months ago by riju_
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] : Dictionaries in IDL are not Web exposed, so remove RuntimeEnabled= . Remove the RuntimeEnabled=WebNFC from IDL files containing dictionaries, as they are not Web exposed, so no need for RuntimeEnabled= on them. Remove some comments which make code more convoluted. Add some more information about the blink IDL compiler bug, because of which we have to use "any" for now. BUG=520391 Committed: https://crrev.com/afc79861e426b234bab879188748c0eca3b82bc5 Cr-Commit-Position: refs/heads/master@{#353792}

Patch Set 1 #

Total comments: 1

Patch Set 2 : re-word comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFCRecord.idl View 1 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
riju_
Fix the comments raised by Peter in https://codereview.chromium.org/1375483002/#msg15
5 years, 2 months ago (2015-10-13 12:45:53 UTC) #2
Peter Beverloo
lgtm (but not an owner, you'll need kenneth to sign off) Thank you for following ...
5 years, 2 months ago (2015-10-13 12:49:03 UTC) #4
kenneth.r.christiansen
https://codereview.chromium.org/1403933003/diff/1/third_party/WebKit/Source/modules/nfc/NFCRecord.idl File third_party/WebKit/Source/modules/nfc/NFCRecord.idl (right): https://codereview.chromium.org/1403933003/diff/1/third_party/WebKit/Source/modules/nfc/NFCRecord.idl#newcode15 third_party/WebKit/Source/modules/nfc/NFCRecord.idl:15: // Blink IDL compiler complains that Object is not ...
5 years, 2 months ago (2015-10-13 12:50:00 UTC) #6
kenneth.r.christiansen
lgtm
5 years, 2 months ago (2015-10-13 12:50:26 UTC) #8
riju_
Thanks Peter :)
5 years, 2 months ago (2015-10-13 13:00:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403933003/20001
5 years, 2 months ago (2015-10-13 14:28:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 18:19:24 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 18:21:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/afc79861e426b234bab879188748c0eca3b82bc5
Cr-Commit-Position: refs/heads/master@{#353792}

Powered by Google App Engine
This is Rietveld 408576698