add inital gm for colorfilters

add inital gm for colorfilters

BUG=skia:
R=djsollen@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13346

[djsollen, 2014-02-06 16:18:38]

https://codereview.chromium.org/140393005/diff/1/gm/colorfilters.cpp
File gm/colorfilters.cpp (right):

https://codereview.chromium.org/140393005/diff/1/gm/colorfilters.cpp#newcode84
gm/colorfilters.cpp:84: // the resulting pdf can be ~700MB and crashes Chrome's
PDF viewer.
remove these comments.

https://codereview.chromium.org/140393005/diff/1/gm/colorfilters.cpp#newcode86
gm/colorfilters.cpp:86: return kSkipPicture_Flag | kSkipPipe_Flag |
kSkipPDF_Flag;
do we want this to skip pictures?

[reed1, 2014-02-06 16:23:43]

https://codereview.chromium.org/140393005/diff/1/gm/colorfilters.cpp
File gm/colorfilters.cpp (right):

https://codereview.chromium.org/140393005/diff/1/gm/colorfilters.cpp#newcode84
gm/colorfilters.cpp:84: // the resulting pdf can be ~700MB and crashes Chrome's
PDF viewer.
On 2014/02/06 16:18:39, djsollen wrote:
> remove these comments.

Done.

https://codereview.chromium.org/140393005/diff/1/gm/colorfilters.cpp#newcode86
gm/colorfilters.cpp:86: return kSkipPicture_Flag | kSkipPipe_Flag |
kSkipPDF_Flag;
On 2014/02/06 16:18:39, djsollen wrote:
> do we want this to skip pictures?

No. Done.

[djsollen, 2014-02-06 16:27:43]

lgtm

[tfarina, 2014-02-06 16:31:33]

https://codereview.chromium.org/140393005/diff/60001/gm/colorfilters.cpp
File gm/colorfilters.cpp (right):

https://codereview.chromium.org/140393005/diff/60001/gm/colorfilters.cpp#newc...
gm/colorfilters.cpp:40: fName.set("lightingcolorfilter");
is this equivalent to:

ColorFiltersGM() : fName("lightingcolorfilter") {} ?

[reed1, 2014-02-06 16:53:06]

On 2014/02/06 16:31:33, tfarina wrote:
> https://codereview.chromium.org/140393005/diff/60001/gm/colorfilters.cpp
> File gm/colorfilters.cpp (right):
> 
>
https://codereview.chromium.org/140393005/diff/60001/gm/colorfilters.cpp#newc...
> gm/colorfilters.cpp:40: fName.set("lightingcolorfilter");
> is this equivalent to:
> 
> ColorFiltersGM() : fName("lightingcolorfilter") {} ?

It is. I expect to modify this guy to take params, in which case I'll be
dynamically creating the name.

[reed1, 2014-02-06 16:53:30]

Committed patchset #2 manually as r13346 (presubmit successful).