Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1403923002: Fix Error object value lookups. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Error object value lookups. Looking up 'name' and 'message' properties at the same time and loading the properties later can cause assertion failure if one of the properties is an accessor and calling it changes the holder map. That may invalidate the other lookup. R=jkummerow@chromium.org BUG=chromium:542101 LOG=N Committed: https://crrev.com/1a94bc20a12254875704c45262e2b87bf85b63f6 Cr-Commit-Position: refs/heads/master@{#31229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M src/messages.cc View 2 chunks +14 lines, -16 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-542101.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 2 months ago (2015-10-13 08:41:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403923002/1
5 years, 2 months ago (2015-10-13 08:57:57 UTC) #3
Jakob Kummerow
lgtm
5 years, 2 months ago (2015-10-13 09:00:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-13 09:20:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403923002/1
5 years, 2 months ago (2015-10-13 09:21:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 09:26:39 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 09:26:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a94bc20a12254875704c45262e2b87bf85b63f6
Cr-Commit-Position: refs/heads/master@{#31229}

Powered by Google App Engine
This is Rietveld 408576698